Re: RFR: 8386473: DESKeySpec and DESedeKeySpec may throw InvalidKeyException instead of ArrayIndexOutOfBoundsException for Integer.MIN_VALUE offset [v2]

[Shawn Emery]

On Sat, 13 Jun 2026 08:37:22 GMT, SendaoYan <s...@openjdk.org> wrote:

>> Shawn Emery has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Updates based on sendaoYan's comments
>
> test/jdk/javax/crypto/spec/DESKeySpec/OffsetKey.java line 29:
> 
>> 27:  * @summary Test DES[ede]KeySpec for negative and integer overflow 
>> offsets
>> 28:  */
>> 29: import java.security.InvalidKeyException;
> 
> 'import InvalidKeyException' seems useless.

Good catch, removed.

> test/jdk/javax/crypto/spec/DESKeySpec/OffsetKey.java line 67:
> 
>> 65:             throw new Exception("expected 
>> ArrayIndexOutOfBoundsException");
>> 66:         } catch (ArrayIndexOutOfBoundsException aiobe) {}
>> 67:         try{
> 
> There are several `try{` missed a whitespace

Fixed in latest delta.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31494#discussion_r3408546687
PR Review Comment: https://git.openjdk.org/jdk/pull/31494#discussion_r3408546158