On Tue, 16 Jun 2026 05:29:02 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2798 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - 8386239: [lworld] Update jdk/java/util/Arrays/ArraysEqCmpTest.java >> >> Reviewed-by: liach >> - 8386242: [lworld] Simplify and clarify StrictProcessor >> >> Reviewed-by: dsimms >> - 8386140: [lworld] FieldReflector using wrong Class argument >> >> Reviewed-by: alanb, dsimms >> - 8386216: [lworld] Rollback meaningless diff in EventClassBuilder >> >> Reviewed-by: dsimms >> - 8385170: [lworld] Serialization spec needs to allow abstract value >> classes like Number >> >> Reviewed-by: liach >> - 8385980: [lworld] Standardize pattern for preview value class generation >> >> Reviewed-by: liach >> - 8386086: [lworld] >> sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java should be >> removed from problem list >> >> Reviewed-by: liach, dcubed >> - Merge >> >> Merge jdk-28+1 >> - 8386090: [lworld] Redundant test changes in lworld versus mainline >> >> Reviewed-by: vromero >> - ... and 2788 more: https://git.openjdk.org/jdk/compare/92298786...4d6d2888 > > src/java.base/share/classes/java/lang/ref/Cleaner.java line 221: > >> 219: * @param action a {@code Runnable} to invoke when the object >> becomes phantom reachable >> 220: * @return a {@code Cleanable} instance >> 221: * @throws IdentityException if the object is not an > > Nit - perhaps reword it as `if {@code obj} is not an ...`? Infact, should the newly added `@throws` specification state that the `IdentityException` is only thrown when value objects preview is enabled? Furthermore, should the newly introduced: Objects.requireIdentity(obj, "obj"); instead be invoked only if `PreviewFeatures.isEnabled()`? I realize that deep within the call of `Objects.requireIdentity`, the preview enabled check does get exercised and this call returns normally when preview is disabled. But it might be more clear here at the call site to use a `PreviewFeatures.isEnabled()` before calling `Objects.requireIdentity()`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3418360701
