On Tue, 16 Jun 2026 06:12:43 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2798 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - 8386239: [lworld] Update jdk/java/util/Arrays/ArraysEqCmpTest.java >> >> Reviewed-by: liach >> - 8386242: [lworld] Simplify and clarify StrictProcessor >> >> Reviewed-by: dsimms >> - 8386140: [lworld] FieldReflector using wrong Class argument >> >> Reviewed-by: alanb, dsimms >> - 8386216: [lworld] Rollback meaningless diff in EventClassBuilder >> >> Reviewed-by: dsimms >> - 8385170: [lworld] Serialization spec needs to allow abstract value >> classes like Number >> >> Reviewed-by: liach >> - 8385980: [lworld] Standardize pattern for preview value class generation >> >> Reviewed-by: liach >> - 8386086: [lworld] >> sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java should be >> removed from problem list >> >> Reviewed-by: liach, dcubed >> - Merge >> >> Merge jdk-28+1 >> - 8386090: [lworld] Redundant test changes in lworld versus mainline >> >> Reviewed-by: vromero >> - ... and 2788 more: https://git.openjdk.org/jdk/compare/92298786...4d6d2888 > > src/java.base/share/classes/java/lang/ref/Reference.java line 543: > >> 541: Reference(T referent, ReferenceQueue<? super T> queue) { >> 542: if (referent != null) { >> 543: Objects.requireIdentity(referent); > > For clarity, should this call be guarded by a check of > `PreviewFeatures.isEnabled()`? It's okay to use this API in the implementation of method in java.base (or other "participates in preview" modules). It's no different to when virtual threads were in preview and we have checked for isVirtual in several places of the implementation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3418537112
