On Tue, 30 Jun 2026 12:32:38 GMT, Sean Mullan <[email protected]> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   comments
>
> src/java.base/share/classes/java/security/cert/X509Certificate.java line 173:
> 
>> 171: 
>> 172:     /**
>> 173:      * Checks that the given instant is within the certificate's
> 
> I prefer if we use the term "date" as this is what [RFC 5280 uses when 
> defining the Validity 
> field](https://www.rfc-editor.org/rfc/rfc5280#section-4.1.2.5), thus I think 
> "date" will be more familiar to users. I suggest the following re-wording:
> 
> "Checks that the given date (represented as an `Instant`) is within the 
> certificate's ..."

This comment is still unaddressed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30047#discussion_r3498715216

Reply via email to