On Wed, 20 May 2026 16:40:13 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/x509/PrivateKeyUsageExtension.java >> line 69: >> >>> 67: >>> 68: private Instant notBefore = null; >>> 69: private Instant notAfter = null; >> >> No need to set to `null`. Also, I think these can be `final`. > > Removed setting to null. These can't be final as there is logic that requires > them to be assigned later in `public PrivateKeyUsageExtension(Boolean > critical, Object value)` Ok. Another way around that is to use local variables in the ctor, and then assign it to the those class variables at the end of the ctor. But we're getting a bit off track into refactoring other code, so I'm ok with leaving as-is. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30047#discussion_r3283062811
