On Tue, 30 Jun 2026 17:02:36 GMT, Andreas Chmielewski <[email protected]> wrote:
> > > How can we make sure this doesn't happen again when new cipher suites are > > > added? > > > > > > Good point, Daniel! > > @chmielewskiandreas How about we add an instructional comment at > > `SSLCipher.java:66`: "Make sure to update SSLAlgorithmDecomposer when > > adding/removing ciphers below"? > > Not sure if this is still needed if we make sure to run my tests by default. > Comments like this tend to mess up the source code. I agree, I don't think such comment is needed now when we ensure the compliance with the test. ------------- PR Comment: https://git.openjdk.org/jdk/pull/31633#issuecomment-4846323146
