On Thu, 30 Jul 2026 12:49:24 GMT, Matthias Baesken <[email protected]> wrote:
> [JDK-8388872](https://bugs.openjdk.org/browse/JDK-8388872) fixed some issues > in the windows pkcs11 native coding, but seems they are also present in the > separate unix coding. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). I'd suggest revising the title to be self-contained rather than referencing the related one, which is already tracked by JBS. > Should we do it on Windows too? I think that's intentional. `LoadLibrary(NULL)` just returns `NULL`, whereas `dlopen(NULL)` returns the main executable. Either way, that seems quite orthogonal to this PR. `if (ckAssertReturnValueOK(env, rv) != CK_ASSERT_OK) {` does look unique to Unix. Also, it raises an exception and causes the connection to drop. For other kinds of failures, we just report the failure and move on, but this branch has more impactful consequences. I'd suggest trying to addressing that in a separate PR. The current PR/patch is clean and trivial. ------------- Marked as reviewed by ayang (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32103#pullrequestreview-4824796748
