On Fri, 31 Jul 2026 06:56:40 GMT, Andreas Chmielewski 
<[email protected]> wrote:

>> I want to propose this enhancement. Please see the CSR.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Andreas Chmielewski has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Review

src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line 
1463:

> 1461:                     return new P11TlsMasterSecretGenerator(
> 1462:                         token, algorithm, mechanism);
> 1463:                 } else if (algorithm == "SunTls12ExtendedMasterSecret") 
> {

It looks like a name mismatch here. Registration uses 
`SunTlsExtendedMasterSecret` at #1035, and instantiation uses 
`SunTls12ExtendedMasterSecret`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32081#discussion_r3732841529

Reply via email to