On Thu, 30 Jul 2026 12:10:38 GMT, Andreas Chmielewski 
<[email protected]> wrote:

>> I want to propose this enhancement. Please see the CSR.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Andreas Chmielewski has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - Review comments
>  - Last auto-formatting broke that test

test/jdk/sun/security/pkcs11/tls/fips/FipsModeTLS.java line 41:

> 39:  * @run main/othervm/timeout=120
> 40:  *      -Djdk.tls.client.protocols=TLSv1.3
> 41:  *      -Djdk.tls.useExtendedMasterSecret=false

What I had in mind was a new line like:

 * @run main/othervm/timeout=120 -Djdk.tls.client.protocols=TLSv1.2
 *      -Djdk.tls.client.enableSessionTicketExtension=false FipsModeTLS

(same as lines 33-35 above except the `-Djdk.tls.useExtendedMasterSecret=false` 
part), and an adjustment to the comment above:

@comment SunPKCS11 does not support (TLS1.2) SunTlsExtendedMasterSecret yet.

this part is no longer true.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32081#discussion_r3683015273

Reply via email to