On Thu, 6 Aug 2026 21:35:48 GMT, Valerie Peng <[email protected]> wrote:

>> Initial commit containing the public API changes and related regression 
>> tests.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Valerie Peng has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   import cleanup.

src/java.base/share/classes/com/sun/crypto/provider/Argon2DerivedKey.java line 
133:

> 131:         }
> 132: 
> 133:         if (isDestroyed()) {

Should this throw for the idendity check as well.. and on the other hand don’t 
we lose the ability to remove it from HashSets once it’s destroyed, for not 
really a good reason?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3811889736

Reply via email to