On Thu, 6 Aug 2026 21:35:48 GMT, Valerie Peng <[email protected]> wrote:
>> Initial commit containing the public API changes and related regression >> tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Valerie Peng has updated the pull request incrementally with one additional > commit since the last revision: > > import cleanup. src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line 286: > 284: /** > 285: * Builds an {@code Argon2ParameterSpec} object from the > specified > 286: * {@code salt}, {@code password}, and builder parameters. I think you need to say which parameters are cloned/copied, ex: "Copies of the salt, password, secret (if specified) and associated data (if specified) are made when creating the `Argon2ParameterSpec` object." ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3815062872
