On Fri, 21 Aug 2026 11:41:15 GMT, Andrew Haley <[email protected]> wrote:
>> Shawn Emery has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implement more comments from theRealAph and adinn
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5115:
>
>> 5113: #ifndef R18_RESERVED
>> 5114: can_use_r18 = true;
>> 5115: #endif
>
> Suggestion:
>
> const bool can_use_r18 = R18_RESERVED_ONLY(false) NOT_R18_RESERVED(true);
Done!
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5169:
>
>> 5167: __ pop(saved_regs, sp);
>> 5168: if (can_use_fp && can_use_r18) {
>> 5169: __ ldr(r18_tls, Address(sp, 96));
>
> Suggestion:
>
> __ ldr(r18_tls, Address(sp, something * wordSize));
With the unconditional logic this is no longer relevant.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32049#discussion_r3849496691
PR Review Comment: https://git.openjdk.org/jdk/pull/32049#discussion_r3849504118
