On Fri, 11 Sep 2026 08:25:10 GMT, Mikhail Yankelevich
<[email protected]> wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed wildcard imports and logging flag; changed to use
>> InetAddress.getLoopbackAddress
>
> test/jdk/sun/security/x509/URICertStore/AIACertTimeout.java line 55:
>
>> 53: import java.security.KeyPairGenerator;
>> 54: import java.security.spec.*;
>> 55: import java.util.*;
>
> Nit: widcard imports
expanded imports
> test/jdk/sun/security/x509/URICertStore/AIACertTimeout.java line 64:
>
>> 62: public class AIACertTimeout {
>> 63:
>> 64: private static final boolean logging = true;
>
> Do you think this should be a test parameter at `@run`?
I think it makes more sense to remove the conditional entirely. I don't see why
anyone would set this to false and we need the logging in case the test fails
again. I removed the flag and made logging unconditional.
> test/jdk/sun/security/x509/URICertStore/AIACertTimeout.java line 136:
>
>> 134:
>> 135: public void start() throws IOException {
>> 136: server.bind(new InetSocketAddress("127.0.0.1", 0), 0);
>
> I personally think it's better to have `InetAddress.getLoopbackAddress()...`
> instead of the hardcoded address. What do you think?
sure
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32814#discussion_r4026312851
PR Review Comment: https://git.openjdk.org/jdk/pull/32814#discussion_r4026324220
PR Review Comment: https://git.openjdk.org/jdk/pull/32814#discussion_r4026325460
