On Fri, 30 Oct 2026 08:32:53 GMT, Daniel Jeliński <[email protected]> wrote:
>> Timofei Fedotov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add number of bug in test
>> - Add test
>
> test/jdk/javax/net/ssl/DTLS/InconsistentFragmentLength.java line 38:
>
>> 36: static ByteBuffer record(int sequence, int length, int offset, int
>> size) {
>> 37: var b = ByteBuffer.allocate(25 + size);
>> 38:
>> b.put((byte)22).put((byte)0xfe).put((byte)0xfd).putShort((short)0);
>
> Can you add comments explaining the bytes you put in the buffer? The are
> pretty obvious when reading this code with a RFC in hand, but it would be
> better if the code was self-evident.
Done.
> test/jdk/javax/net/ssl/DTLS/InconsistentFragmentLength.java line 59:
>
>> 57:
>> 58: public static void main(String[] args) throws Exception {
>> 59: var engine = engine(); var app = ByteBuffer.allocate(65536);
>
> Suggestion:
>
> var engine = engine();
> var app = ByteBuffer.allocate(65536);
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33633#discussion_r4422181624
PR Review Comment: https://git.openjdk.org/jdk/pull/33633#discussion_r4422181893
