On Thu, 12 Nov 2026 07:57:26 GMT, Timofei Fedotov <[email protected]> wrote:

> PKCS12KeyStore.loadSafeContents() reads valSet[0] for friendlyName and 
> localKeyId attributes without checking whether their DER SET contains any 
> values.
> 
> DerInputStream.getSet(1) accepts an empty SET; the argument controls initial 
> collection capacity rather than a minimum element count. A malformed PKCS12 
> bag attribute containing SET encoding 3100 therefore produces a zero-length 
> array and triggers ArrayIndexOutOfBoundsException during KeyStore.load(). The 
> unencrypted content path can encounter the error with a null password.
> 
> Expected behavior: invalid attribute encodings must produce the normal 
> IOException parsing failure instead of an unchecked indexing exception.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 2393:

> 2391:                         if (valSet.length == 0) {
> 2392:                             throw new IOException("Empty attribute 
> value set");
> 2393:                         }

Not sure. Maybe it can be empty for some attributes. There is no need to add 
this restriction.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33864#discussion_r4574467143

Reply via email to