First of all: thanks a lot. Comments inline.
On Donnerstag, 6. März 2008, Louis Gerbarg wrote: > I was getting errors trying to store dates in the mid 2290s... I thought my schedule was packed with meetings, and you are already planning until the 2290s. What kind of site is that? > here is > a patch that remedies this. It was tested under php 5.2.5 on Mac OS X > 10.5.2 (32 bit). The patch should run correctly on php >= 5.1.3, > though I suspect it will not actually give people the extended ranges > unless you are on more recent releases due to fixes in the DateTime > class. If I did everything correctly it should still accept all the > same input formats it previously did, as well as store everything in > the database the same way, so no data conversion should be necessary, > but I did not test that extensively. How does that work? Can the DB handle 64bit large numbers? Is there a performance hit associated to that? I now have already two patches for extending data ranges: the other one is the Historical Date datatype by Terry A. Hurlbut. I wonder whether this extended datatype could also use your method (AFAIK the historical dates use days instead of seconds internally, right?). I also consider switching to a format that separates parts of dates in different DB fields, so that SMW can distinguish dates without exact day or day time from those dates which just happen to be at a year's 1st of Jan 00:00 ... this would probably also solve the 64bit issue since the components would fit into 32bit. > > This patch should not be necessary if you are running a php 5.2 > snapshot build on a 64 bit platform, but I think it is still > worthwhile since limiting extended ranges to 64 bit machines is > probably not optimal ;-) > > There was a bit of patch fuzz because of changes in > exportData/exportRDF after I ran the tests, it looks like it should be > a non-issue. Yes, I changed the export code substantially, but that should not affect anything else. Markus -- Markus Krötzsch Institut AIFB, Universität Karlsruhe (TH), 76128 Karlsruhe phone +49 (0)721 608 7362 fax +49 (0)721 608 5998 [EMAIL PROTECTED] www http://korrekt.org
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ Semediawiki-devel mailing list Semediawiki-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/semediawiki-devel
