Neil, thanks a lot! Contributions are very welcome.
On Freitag, 14. August 2009, Sergey Chernyshev wrote: > Neil, > > Usually it's done by filing a bug in Bugzilla and attaching a patch. Yes, this is the preferred solution in this case. In particular, there is a reason why the JSON is invalid: Exhibit, the main consumer application of SMW's JSON, expects it to be like this. We hope that this is fixed at some point, or we will need to introduce some parameter for controlling this behaviour in order to preserve a way of using the exports in Exhibit (e.g. as on http://beer.geekworks.de/). There has also been some discussion on this on this list recently about the issue, but I do not have a pointer now. If I have recalled this thread correctly here, then we should probably add an according explanation to the code (since it is the only thing anyone is bound to look at when investigating this issue). The solution for the other issue you mention should be easier to integrate, so separate patches would be nice. > > But there is also a way to get commit access here: > http://www.mediawiki.org/wiki/Commit_access This is certainly a good thing if you want to get more deeply into MW extension development. When doing non-trivial changes, it is still good to send a note/explanation to this list, to avoid confusion among other developers (and sometimes, as in this case, there might be unexpected side- effects to an seemingly straightforward fix). Regards, Markus > > Sergey > > > -- > Sergey Chernyshev > http://www.sergeychernyshev.com/ > > On Fri, Aug 14, 2009 at 10:48 AM, Neil Davies <neiladav...@gmail.com> wrote: > > Hi All, > > > > I have a found several bugs in SMW_QP_JSONlink.php. In summary these are: > > > > - It produces invalid JSON (the keys are not always enclsoed in > > quotes) - It fails on certain queries - namely when you specify a query > > to retrieve certain values from a particular page > > > > I've tested it fairly well and would like to commit it to SVN but don't > > have write access. I send the fix to this list, but I don't think that's > > the best way to do it. How do I go about getting write access? > > > > Neil > > > > > > ------------------------------------------------------------------------- > >----- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > > 30-Day trial. Simplify your report design, integration and deployment - > > and focus on > > what you do best, core application coding. Discover what's new with > > Crystal Reports now. http://p.sf.net/sfu/bobj-july > > _______________________________________________ > > Semediawiki-devel mailing list > > Semediawiki-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/semediawiki-devel -- Markus Krötzsch <mar...@semantic-mediawiki.org> * Personal page: http://korrekt.org * Semantic MediaWiki: http://semantic-mediawiki.org * Semantic Web textbook: http://semantic-web-book.org
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________ Semediawiki-devel mailing list Semediawiki-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/semediawiki-devel
