Hi Oliver,
thanks for the fix! It's implemented in
https://gerrit.wikimedia.org/r/#/c/68218/
Cheers,
Stephan
On 12 June 2013 00:03, Oliver Lutzi <oliverlu...@gmx.de> wrote:
> Hey,
>
> I encountered the same problem (using a different extension). Basil Ell
> and I figured out that the source of the bug is line 84 of the file
> "SF_popupform.js".
>
> You use the "setInterval()" method to call a function at specified
> intervals and escape it once "window.readystate" returns "interactive".
> As described in [1], "readystate" chages its return values from
> "loading" to "interactive" and finally to "complete". If "readystate"
> happens to change from state "loading" to "complete" between two calls,
> the script never escapes "setInterval()" because the state "interactive"
> was never observed.
>
> Therefore: Change the code in line 84 from
>
> if ( readystate === 'interactive' ) {
>
> to
>
> if ( readystate === 'interactive' || readystate === 'complete' ) {
>
>
> and the bug should be fixed.
>
>
> Best regards,
> Oliver Lutzi
>
>
> [1] https://developer.mozilla.org/en-US/docs/Web/API/document.readyState
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Semediawiki-devel mailing list
> Semediawiki-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/semediawiki-devel
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Semediawiki-devel mailing list
Semediawiki-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/semediawiki-devel
