On Apr 12, 10:52 am, John Firebaugh <[email protected]> wrote: > On Sat, Apr 10, 2010 at 11:56 AM, Jeremy Evans <[email protected]>wrote: > > > A different approach is to add additional options to the save method, > > which currently accepts :changed, :transaction, > > and :validate. :transaction overrides the use_transactions flag if > > present, but there isn't a option to override the > > raise_on_save_failure flag (one could be added, but nobody has > > requested it). > > I did!
Sorry, I obviously forgot about that. :) I guess the reason it never got merged is that nobody else felt strongly about it, and I'm still on the fence. Don't get me wrong, it's probably the best way to add the option, but it's a lot of code churn for what I see as a minor benefit. > I also agree that accepting options is a nicer approach in general. I agree as well, it's purely a cost/benefit issue with me. I'm still open to accepting that patch, if other Sequel users feel strongly in favor of it. Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en.
