Hi guys, I've already made some changes to the logging in SER. The log messages will automatically include the severity, the position (filename and line) and the module name (or "<core>"/"<script>" string). Currently, it's being reviewed by Jan Janak.
Moreover, I wrote a script that replaces LOG(static_severity, ...) by corresponding dedicated macros and removes the module name and the severity string from the log messages in SER sources. Regards --ondra Bogdan Pintea wrote: > I was actually wondering: shouldn't all logging be, finally, leveled? > > Right now, there are 3 logging types: > - using dedicated macros for severity (ERR, WARN etc); > - LOG(<severity>, ...), manually beautified -- severity and maybe > function name present (the case of current commit); > - as previous, but either no severity or no location info, or both missing; > > This is "hard" to deal with, both for a human and an automated log > parser (besides the unprofessional, chaotic looks :-) ) . > > Are there clear disadvantages against sticking to only logging with > dedicated severity macros and (progressively) migrate all log statements > to that model? > > > Bogdan. > > PS. I know not all compilers in all their versions have location helpers > and that manual beautifying helps with those, but this support should > nowadays be marginally (if at all) needed; besides, current status is > mixed enough to be uncomfortable in those situations, as well. > > Nils Ohlmeier wrote: >> calrissian 2008/08/24 00:15:43 CEST >> >> SER CVS Repository >> >> Modified files: >> . forward.c >> Log: >> fixed wrong function name in error message >> >> Revision Changes Path >> 1.118 +2 -2 sip_router/forward.c >> http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/forward.c.diff?r1=1.117&r2=1.118 >> _______________________________________________ >> Serdev mailing list >> [email protected] >> http://lists.iptel.org/mailman/listinfo/serdev >> >> > > _______________________________________________ Serdev mailing list [email protected] http://lists.iptel.org/mailman/listinfo/serdev
