On a related note (and will I'm in that area) I'd like to depracate remove(MailImpl) remove(String) And replace them with remove(collection<String>) I would like to promote remove(collection<String>) as the primary access method for repositories, rather than the single remove actions because in most repository implementations (SQL and mbox) the mass delete is considerably more efficent. In the case of the Avalon repositories I don't think it makes much difference.
Any comments? P.S. I hadn't planned to do my option 2 just yet :) > -----Original Message----- > From: Noel J. Bergman [mailto:[EMAIL PROTECTED] > Sent: 19 August 2003 17:14 > To: James Developers List > Subject: RE: [PATCH] mbox mail repository V2 > > > > No, I think you're right. [Collection<String>] is easier > for the mbox > > repository, but it's not a big issue. The > remove(Collection<MailImpl>) > > is probably for the best. > > Trivial isomorphism: key == mail.getName() > > > There are two options here: > > 1) I implement the remove(Collection<MailImpl>) using the current > > MailRepository system and leave it at that. This could then be > > used in v2 and early v3. The work for this is almost done. Oh, > > and sort out the exceptions as well. > > > 2) I will try and come up with an initial design for a JavaMail > > implementation. This is NOT a quick fix :) > > Let's start with #1, which we can use *now*. :-) > > > My current [choice] would be to use javax.mail.MessagingException. > > This is because when we finally implement JavaMail storage I think > > that these are the exceptions the storage implementations should be > > throwing. > > Makes sense, assuming that we do adopt JavaMail for the mail > storage interface. Seems like a reasonable approach for now. > > --- Noel > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
