Robert Burrell Donkin ha scritto:
On Mon, Jul 21, 2008 at 2:37 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote:
<snip>
The other 3 I see are in MessageWriteToTest
- testBinaryAttachmentLenient
- testBinaryAttachmentStrictError
- testBinaryAttachmentStrictIgnore
They have been broken while Niklas fixed the quoted-printable decoding
issue. I'm not sure the expected result was correct. The current result is
"rfc wise" correct even if we are replacing all spaces with =20 and this is
discouraged for text bodies.
The current QuotedPrintable OutputStream does not support "suggested"
behaviour of escaping SPACES and TABS only at the end of a line, so there is
another thread/JIRA issue about this
(https://issues.apache.org/jira/browse/MIME4J-62)
these tests look right to me: the code's bust
Expected result expected non encoded spaces.
Before MIME4J-59 fix mime4j was not correctly decoding/encoding quoted
printable stuff for text parts.
From my understanding If we fix MIME4J-59 but we don't fix MIME4J-62
then we have to change the expected result.
I can try to fix MIME4J-62 but I'll probably evaluate commons-net
classes before putting my hands in our custom code, so I'll do this only
if people agree it is good and no one has a better alternative.
If you think that we have to revert the fix for MIME4J-59 fix I don't
have issues. Just ask Niklas if he agrees to.
Stefano
PS: Robert, I think no one ever complained because we had JAMES Server
failing to build because of IMAP issues, that's why I don't understand
your reaction to this mime4j status.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
