[
https://issues.apache.org/jira/browse/MIME4J-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659064#action_12659064
]
Stefano Bagnara commented on MIME4J-60:
---------------------------------------
I just reviewed the diff, no time for a better check. Everything seems ok and
you added a lot of tests!
maybe MimeMode does not need anything but the 2 constants, and maybe it could
be a java5 enum (I don't remember how Markus dealt with enum in the java5
upgrade, and I have no checkout here).
Have you seen any performance change due to this refactoring?
> Configurable strategy for line delimiters
> -----------------------------------------
>
> Key: MIME4J-60
> URL: https://issues.apache.org/jira/browse/MIME4J-60
> Project: JAMES Mime4j
> Issue Type: Wish
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.6
>
> Attachments: mime4j-60-phase1.patch,
> MIME4J-60-readLine-returns-no-newline.patch, newlines-tests.zip
>
>
> There is an ongoing discussion about how we should deal with non canonical
> line endings (isolated LF and/or isolated CR).
> This issue is to track discussion results and proposed patches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
