On Jun 14, 2009, at 11:06 AM, Norman Maurer wrote:

Hi guys,

here is the VOTE for release jSPF 0.9.7. Please cast your VOTE after review:

http://people.apache.org/~norman/staging-repository/org/apache/james/jspf/apache-jspf/0.9.7/

I'm confused by a few things.

I'm really confused by the two LICENSE files and two NOTICE files. Not being a lawyer I think I'd have to consult one before considering using the product. I'm not sure how anyone could figure out which file applies to the product.

My understanding of apache policy is that the legal files are supposed to describe and apply to exactly what is in the artifact that contains them. I didn't do a complete search but suspect from the language that the larger LICENSE and NOTICE files also include information about dependencies such as junit that are not actually redistributed. The notice file also has some "thanks for the inspiration" notes that don't seem to me appropriate for the NOTICE file. Again, its only my impression of apache policy, but I think the NOTICE file is supposed to be as short as possible and only include the standard apache notice and anything legally required by external code that is actually included in the artifact.

The BUILDING.txt and README.txt don't have apache license headers. I'm really not sure if they are required to, but adding them removes all questions from sticklers like me :-)

On a much less important subject, it looks like you have a maven build but I don't see a maven repo structure in the staging area that includes the actual jars. Is there a plan to deploy the jars to maven central? I guess looking closer there's a private svn repo in stage so deploying the jars is not a good idea since the dependencies must not be in central. Since this is a somewhat unusual way to use maven it might be helpful to explain it in the BUILDING file and note that for this reason neither snapshots nor releases should be deployed to public maven repos.

I think it might be a good idea to fix the legal files content and make sure only one LICENSE and one NOTICE file are present. I'd make this into more of a standard up to date maven project but that is a matter of taste.

thanks
david jencks


[  ] +1 Please release it as it is
[  ] +0 Sorry no real idea about it
[  ] -1 No please not....


Thx,
Norman

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to