[
https://issues.apache.org/jira/browse/MAILBOX-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980165#action_12980165
]
Eric Charles commented on MAILBOX-14:
-------------------------------------
You can see a first shot on james-jpa-db-1-without-mailbox-fk.png
(https://issues.apache.org/jira/secure/attachment/12468023/james-jpa-db-1-without-mailbox-fk.png)
- All tables are prefixed with JAMES_
- Columns names are prefixed with a "context" (example: JAMES_MAIL_PROPERTY
columns all begin with PROPERTY). I find this often useful even if it obliges
to type a bit more in the SQL queries, but to be discussed.
- PK and FK are suffixed with _SID (System Identitifer)
The column length are often arbitrary. We need to review them, and also maybe
have a constant for the default value.
What about the @Basic(optional=false) and @Column(... nullable = false, ...):
It's double if I understand well. which one should we use ? (I would go for the
@Column nullable)
Other point is the potential FK between JAMES_MAILBOX and
JAMES_MAILBOX_MEMBERSHIP (see
https://issues.apache.org/jira/secure/attachment/12468024/james-jpa-db-1-with-mailbox-fk.png)
I defined the annotations, updated the queries, but didn't succeed to make it
work completely.
With a bit more investment, I guess it would be possible to let it work.
However, I saw that adding that FK would oblige JPA to make more queries (load
the Mailbox entities) -> we could loose some performance.
On a datamodel level, the FK is welcome. On a performance, it is not sure.
WDYT?
> Name JPA Database Tables and Columns
> ------------------------------------
>
> Key: MAILBOX-14
> URL: https://issues.apache.org/jira/browse/MAILBOX-14
> Project: James Mailbox
> Issue Type: Improvement
> Reporter: Eric Charles
> Attachments: james-jpa-db-1-with-mailbox-fk.png,
> james-jpa-db-1-without-mailbox-fk.png
>
>
> The database tables and columns naming are delegated to OpenJPA. This depends
> on the database.
> We should fix them via JPA annotations so we have predictive and common
> behaviour on all databases (mysql, oracle,...).
> We should respect the uppercase and underscore pattern (TABLE_NAME,
> COLUMN_NAME).
> All JPA Domain classes need to be adapted (mailbox) in IMAP, but also in
> server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
