[ https://issues.apache.org/jira/browse/MAILBOX-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981234#action_12981234 ]
Eric Charles commented on MAILBOX-14: ------------------------------------- http://svn.apache.org/viewvc?rev=1058527&view=rev http://svn.apache.org/viewvc?rev=1058528&view=rev - Used ID instead of SID (more common in the industry) - Still both @Basic(optional=false) and @Column(nullable=false): I think they have different goals/scope Still datamodel to change with additional FK. > Name JPA Database Tables and Columns > ------------------------------------ > > Key: MAILBOX-14 > URL: https://issues.apache.org/jira/browse/MAILBOX-14 > Project: James Mailbox > Issue Type: Improvement > Reporter: Eric Charles > Attachments: james-jpa-db-1-with-mailbox-fk.png, > james-jpa-db-1-without-mailbox-fk.png > > > The database tables and columns naming are delegated to OpenJPA. This depends > on the database. > We should fix them via JPA annotations so we have predictive and common > behaviour on all databases (mysql, oracle,...). > We should respect the uppercase and underscore pattern (TABLE_NAME, > COLUMN_NAME). > All JPA Domain classes need to be adapted (mailbox) in IMAP, but also in > server. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org