Hi Gazda, First of all, thx for pushing this!
(1) I would love to see the current activity in protocols-imap. I had to postpone my contribution on the integration (b4 release and many other stuff), but next week should be a good week for me to work on this. I propose you continue your implementations in protocols-imap (hoping you don't have to backport too much from apache-james-imap such as the tests, and hoping also we can work together on the same codebase, on my side more regarding the integration of the processors in the protocol handler chain).
(2) Your tests use mocks and no concrete processor, I think this is the good way to do the unit tests in this case.
Thx, Eric On 09/03/12 12:27, Jochen Gazda wrote:
Gentlemen, just reposting my old questions. I would like to proceed with https://issues.apache.org/jira/browse/IMAP-358 Enforce rights required to perform different IMAP4rev1 Commands in IMAP processors. (1) Is there something new with protocols-imap vs. apache-james-imap? (2) Tests: Is there a recommended way how to test the enforcement of the individual rights in James? I have written some tests for GETACL, SETACL, LISTRIGHTS, MYRIGHTS and DELETERIGHTS in the apache-james-imap-processor project. All of them are directed towards the respective processors. Could please somebody review esp. the test*Right*() methods in them and tell me if it is sufficient to test the security of other IMAP commands in this way? Best, gazda --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
-- eric | http://about.echarles.net | @echarles --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
