Eric, In my wokspace, I have:
(1) changed the pom's in that way that that the protocols-imap code is used instead of apache-james-imap. (2) merged apache-james-imap classes and tests into protocols-imap classes and tests. (3) moved FetchGroupImpl and PartContentDescriptorImpl from protocols-imap to mailbox-api to be able to remove the imap dependency from james-server-mailets. To sum up, I have changes in the following projects: - apache-james - apache-james-mailbox-api - james-server - james-server-mailets - james-server-protocols-imap4 - protocols - protocols-imap As the changes go over several projects, I needed to set the current snapshots as dependendencies in some pom's. May I commit all my changes? Best, gazda On Fri, Mar 16, 2012 at 10:35 AM, Eric Charles <e...@apache.org> wrote: > Hi Gazda, > > You have to remove in the server's project pom all references to > apache-james-imap-* and replace them by the unique protocols-imap (same in > app). > > Doing this, you will have a few compilation failures that should be easily > solved by changing the package imports. > > You can commit for server project, but wait before committing the app > project that the 3.0b4 release is done. > > Thx, > Eric > > > On 16/03/12 08:42, Jochen Gazda wrote: >> >> Eric, >> >> I just wanted to merge the ACL code from apache-james-imap to >> protocols-imap, but I am still seeing the default build& run to use >> >> the apache-james-imap code. Is there some simple way how I could tell >> James to switch to the protocols-imap code? >> >> Thank you, >> >> gazda >> >> On Fri, Mar 9, 2012 at 2:14 PM, Eric Charles<e...@apache.org> wrote: >>> >>> (snip) >>> >>>> I have not started yet. I will have a look at the diffs between >>>> protocols-imap and apache-james-imap in the next days and backport all >>>> the necessary stuff. >>>> >>> >>> Cool! >>> >>> >>>>> (2) Your tests use mocks and no concrete processor, I think this is the >>>>> good >>>>> way to do the unit tests in this case. >>>> >>>> >>>> >>>> Hm... You say "no concrete processor"? Did you not want to say >>>> something else? For every test in question, the particular processor >>>> of the respective IMAP command IS actually being tested. >>>> Perhaps you wanted to say "no concrete storage impementation"? >>>> >>> >>> Oops, yes, I meant 'no concrete mailbox'. >>> >>> >>>> Best, >>>> >>>> gazda >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org >>>> For additional commands, e-mail: server-dev-h...@james.apache.org >>>> >>> >>> -- >>> eric | http://about.echarles.net | @echarles >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org >>> For additional commands, e-mail: server-dev-h...@james.apache.org >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org >> For additional commands, e-mail: server-dev-h...@james.apache.org >> > > -- > eric | http://about.echarles.net | @echarles > > --------------------------------------------------------------------- > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > For additional commands, e-mail: server-dev-h...@james.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
