Author: matthieu
Date: Tue Jan 26 10:22:12 2016
New Revision: 1726759
URL: http://svn.apache.org/viewvc?rev=1726759&view=rev
Log:
JAMES-1669 switch all fields that can be final based on Intellij static analysis
Modified:
james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/ClusterFactory.java
james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/SessionWithInitializedTablesFactory.java
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/FlagsBuilder.java
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/acl/SimpleGroupMembershipResolver.java
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/MessageRange.java
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/SimpleMailboxACL.java
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/UpdatedFlags.java
james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/mock/MockMailboxManager.java
james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/mock/MockMailboxSession.java
james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/util/EventCollector.java
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CacheInvalidatingMailboxListener.java
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMailboxMapper.java
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMailboxSessionMapperFactory.java
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMessageMapper.java
james/project/trunk/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/CassandraMailboxManager.java
james/project/trunk/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/user/CassandraSubscriptionMapper.java
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/IndexCreationFactory.java
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/json/HeaderCollection.java
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/json/MimePart.java
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/query/CriterionConverter.java
james/project/trunk/mailbox/elasticsearch/src/test/java/org/apache/james/mailbox/elasticsearch/EmbeddedElasticSearch.java
james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/io/ChunkOutputStream.java
james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/HBaseMailboxMessage.java
james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/model/HBaseMailbox.java
james/project/trunk/mailbox/hbase/src/test/java/org/apache/james/mailbox/hbase/mail/HBaseMailboxMessageMapperTest.java
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/AbstractJCRScalingMapper.java
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/GlobalMailboxSessionJCRRepository.java
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/JCRMailboxSessionMapperFactory.java
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/JCRRepositoryAuthenticator.java
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/MailboxSessionJCRRepository.java
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRModSeqProvider.java
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRUidProvider.java
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/user/model/JCRSubscription.java
james/project/trunk/mailbox/jcr/src/test/java/org/apache/james/mailbox/jcr/JCRSubscriptionManagerTest.java
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAModSeqProvider.java
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAUidProvider.java
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/AbstractJPAMailboxMessage.java
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/EncryptDecryptHelper.java
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAEncryptedMailboxMessage.java
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAMailboxMessage.java
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAStreamingMailboxMessage.java
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/openjpa/OpenJPAMailboxManager.java
james/project/trunk/mailbox/kafka/src/main/java/org/apache/james/mailbox/kafka/KafkaMessageConsumer.java
james/project/trunk/mailbox/lucene/src/main/java/org/apache/james/mailbox/lucene/search/UpperCaseFilter.java
james/project/trunk/mailbox/lucene/src/test/java/org/apache/james/mailbox/lucene/search/LuceneMailboxMessageSearchIndexTest.java
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirFolder.java
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirMessageName.java
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirStore.java
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/UidConstraint.java
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMailboxMapper.java
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMailboxMessage.java
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/user/MaildirSubscriptionMapper.java
james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/InMemoryMailboxSessionMapperFactory.java
james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/InMemoryMessageMapper.java
james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryPerUserMaxQuotaManager.java
james/project/trunk/mailbox/spring/src/main/java/org/apache/james/mailbox/spring/SpringMailbox.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/GroupFolderResolver.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/MessageResultImpl.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/SimpleMessageMetaData.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMessageResultIterator.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/event/MailboxListenerRegistry.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/json/SimpleMailboxACLJsonConverter.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleMailbox.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleProperty.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaChecker.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaImpl.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaRootImpl.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/ListeningMessageSearchIndex.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/comparator/HeaderDisplayComparator.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/BodyOffsetInputStream.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/FullByteContent.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/InputStreamContent.java
james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/streaming/PartContentBuilder.java
james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/MailboxEventDispatcherTest.java
james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/MockAuthenticator.java
james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/SimpleMailboxMembership.java
james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/json/SimpleMailboxACLJsonConverterTest.java
james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/BayesianAnalysis.java
james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/BayesianAnalysisFeeder.java
james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/CorpusLoaderThread.java
james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/JDBCBayesianAnalyzer.java
james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/SqlResources.java
james/project/trunk/mailet/api/src/main/java/org/apache/mailet/HostAddress.java
james/project/trunk/mailet/base/src/main/java/org/apache/mailet/base/MatcherInverter.java
james/project/trunk/mailet/base/src/main/java/org/apache/mailet/base/RFC822DateFormat.java
james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMail.java
james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMailContext.java
james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMailetConfig.java
james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMatcherConfig.java
james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMimeMessage.java
james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/SMIMEKeyHolder.java
james/project/trunk/mailet/mailetdocs-maven-plugin/src/main/java/org/apache/james/mailet/AbstractMailetdocsReport.java
james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/ClassifyBounce.java
james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/MailAttributesToMimeHeaders.java
james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/RemoveMailAttribute.java
james/project/trunk/mailet/standard/src/main/java/org/apache/james/transport/mailets/SetMailAttribute.java
james/project/trunk/mpt/antlib/src/main/java/org/apache/james/mpt/ant/MailProtocolTestTask.java
james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ByteBufferInputStream.java
james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ByteBufferOutputStream.java
james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/helper/ScriptBuilder.java
james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/protocol/ProtocolSession.java
james/project/trunk/mpt/core/src/main/java/org/apache/james/mpt/script/AbstractSimpleScriptedTestProtocol.java
james/project/trunk/mpt/impl/imap-mailbox/cassandra/src/test/java/org/apache/james/mpt/imapmailbox/cassandra/host/CassandraHostSystem.java
james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/imapmailbox/MailboxCreationDelegate.java
james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/imapmailbox/suite/ACLCommands.java
james/project/trunk/mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/session/ImapSessionImpl.java
james/project/trunk/mpt/impl/imap-mailbox/cyrus/src/test/java/org/apache/james/mpt/imapmailbox/cyrus/host/GrantRightsOnCyrusHost.java
james/project/trunk/mpt/impl/imap-mailbox/cyrus/src/test/java/org/apache/james/mpt/imapmailbox/cyrus/host/MailboxMessageAppenderOnCyrusHost.java
james/project/trunk/mpt/impl/imap-mailbox/hbase/src/test/java/org/apache/james/mpt/imapmailbox/hbase/host/HBaseHostSystem.java
james/project/trunk/mpt/impl/managesieve/core/src/main/java/org/apache/james/mpt/host/ManageSieveSession.java
james/project/trunk/protocols/api/src/test/java/org/apache/james/protocols/api/AbstractProtocolTransportTest.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/display/CharsetUtil.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/FetchData.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/IdRange.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/SearchKey.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/MailboxType.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/main/DefaultImapDecoder.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/ImapParserFactory.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/AbstractMailboxSelectionRequest.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/CompressRequest.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetQuotaRequest.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/request/StoreRequest.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/AbstractListingResponse.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/ESearchResponse.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/QuotaResponse.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/VanishedResponse.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/CompressProcessor.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/StartTLSProcessor.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/XListProcessor.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/base/AbstractChainedProcessor.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/PartialFetchBodyElement.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/utils/EolInputStream.java
james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/utils/FixedLengthInputStream.java
james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/decode/ImapRequestStreamLineReader.java
james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/encode/FetchResponseEncoderEnvelopeTest.java
james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/processor/base/MailboxEventAnalyserTest.java
james/project/trunk/protocols/netty/src/main/java/org/apache/james/protocols/netty/ChannelGroupHandler.java
james/project/trunk/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/core/TopCmdHandler.java
james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPConfigurationImpl.java
james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java
james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/DNSRBLHandler.java
james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java
james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/hook/HookResult.java
james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/modules/server/ActiveMQQueueModule.java
james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/modules/server/EmbeddedActiveMQ.java
james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/GuiceMailboxManagerResolver.java
james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/GuiceServerProbe.java
james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/InMemoryMailRepositoryStore.java
james/project/trunk/server/container/cassandra-guice/src/test/java/org/apache/james/modules/TestFilesystemModule.java
james/project/trunk/server/container/core/src/main/java/org/apache/james/core/MimeMessageInputStream.java
james/project/trunk/server/container/core/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java
james/project/trunk/server/container/core/src/main/java/org/apache/james/core/filesystem/UrlResource.java
james/project/trunk/server/container/jetty/src/main/java/org/apache/james/http/jetty/Configuration.java
james/project/trunk/server/container/jetty/src/main/java/org/apache/james/http/jetty/JettyHttpServer.java
james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/resource/DefaultJamesResourceLoader.java
james/project/trunk/server/container/spring/src/test/java/org/apache/james/container/spring/filesystem/FileSystemImplTest.java
james/project/trunk/server/container/util/src/main/java/org/apache/james/util/concurrent/NamedThreadFactory.java
james/project/trunk/server/data/data-cassandra/src/test/java/org/apache/james/rrt/cassandra/CassandraStepdefs.java
james/project/trunk/server/data/data-file/src/test/java/org/apache/james/rrt/file/XMLStepdefs.java
james/project/trunk/server/data/data-jdbc/src/test/java/org/apache/james/rrt/jdbc/JDBCStepdefs.java
james/project/trunk/server/data/data-jpa/src/test/java/org/apache/james/rrt/jpa/JPAStepdefs.java
james/project/trunk/server/data/data-library/src/main/java/org/apache/james/repository/file/ClassLoaderObjectInputStream.java
james/project/trunk/server/dns-service/dnsservice-dnsjava/src/test/java/org/apache/james/dnsservice/dnsjava/DNSJavaServiceTest.java
james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/jmx/MailProcessorManagement.java
james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/jmx/MatcherManagement.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/BypassAuthOnRequestMethod.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/json/MultipleClassesDeserializer.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/json/MultipleObjectMapperBuilder.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/GetMessagesMethod.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/ContinuationTokenResponse.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/FilterCondition.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/FilterOperator.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMailboxesRequest.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMailboxesResponse.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessageListRequest.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessageListResponse.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessagesRequest.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/Message.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/MessageProperty.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/SubMessage.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/mailbox/Role.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/message/HeaderCollection.java
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/message/MimePart.java
james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/AbstractCommandHandlerStats.java
james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/ConnectHandlerStats.java
james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/LineHandlerStats.java
james/project/trunk/server/protocols/protocols-managesieve/src/main/java/org/apache/james/managesieveserver/netty/ManageSieveServer.java
james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/jmx/HookStats.java
james/project/trunk/server/queue/queue-activemq/src/main/java/org/apache/james/queue/activemq/MimeMessageBlobMessageSource.java
james/project/trunk/server/queue/queue-file/src/main/java/org/apache/james/queue/file/FileMailQueue.java
Modified:
james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/ClusterFactory.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/ClusterFactory.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/ClusterFactory.java
(original)
+++
james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/ClusterFactory.java
Tue Jan 26 10:22:12 2016
@@ -30,8 +30,8 @@ import com.google.common.collect.Immutab
public class ClusterFactory {
public static class CassandraServer {
- private String ip;
- private int port;
+ private final String ip;
+ private final int port;
public CassandraServer(String ip, int port) {
this.ip = ip;
Modified:
james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/SessionWithInitializedTablesFactory.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/SessionWithInitializedTablesFactory.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/SessionWithInitializedTablesFactory.java
(original)
+++
james/project/trunk/backends-common/cassandra/src/main/java/org/apache/james/backends/cassandra/init/SessionWithInitializedTablesFactory.java
Tue Jan 26 10:22:12 2016
@@ -26,7 +26,7 @@ import org.apache.james.backends.cassand
public class SessionWithInitializedTablesFactory {
private final static String DEFAULT_KEYSPACE_NAME = "apache_james";
- private CassandraModule module;
+ private final CassandraModule module;
public SessionWithInitializedTablesFactory(CassandraModule module) {
this.module = module;
Modified:
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/FlagsBuilder.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/FlagsBuilder.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/FlagsBuilder.java
(original)
+++
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/FlagsBuilder.java
Tue Jan 26 10:22:12 2016
@@ -23,7 +23,7 @@ import javax.mail.Flags;
public class FlagsBuilder {
- private Flags internalFlags;
+ private final Flags internalFlags;
public FlagsBuilder() {
internalFlags = new Flags();
Modified:
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/acl/SimpleGroupMembershipResolver.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/acl/SimpleGroupMembershipResolver.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/acl/SimpleGroupMembershipResolver.java
(original)
+++
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/acl/SimpleGroupMembershipResolver.java
Tue Jan 26 10:22:12 2016
@@ -67,7 +67,7 @@ public class SimpleGroupMembershipResolv
}
- private Set<Membership> memberships = new
HashSet<SimpleGroupMembershipResolver.Membership>(32);
+ private final Set<Membership> memberships = new
HashSet<SimpleGroupMembershipResolver.Membership>(32);
public void addMembership(String group, String user) {
memberships.add(new Membership(user, group));
Modified:
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/MessageRange.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/MessageRange.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/MessageRange.java
(original)
+++
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/MessageRange.java
Tue Jan 26 10:22:12 2016
@@ -233,7 +233,7 @@ public class MessageRange implements Ite
*/
private final class RangeIterator implements Iterator<Long> {
- private long to;
+ private final long to;
private long current;
public RangeIterator(long from, long to) {
Modified:
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/SimpleMailboxACL.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/SimpleMailboxACL.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/SimpleMailboxACL.java
(original)
+++
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/SimpleMailboxACL.java
Tue Jan 26 10:22:12 2016
@@ -221,7 +221,7 @@ public class SimpleMailboxACL implements
/**
* See RFC 4314 section 2.1.1. Obsolete Rights.
*/
- private CompatibilityMode compatibilityMode =
CompatibilityMode.ckx_det;
+ private final CompatibilityMode compatibilityMode =
CompatibilityMode.ckx_det;
/**
* 32 bit <code>int</code> to store the rights.
@@ -798,9 +798,9 @@ public class SimpleMailboxACL implements
}
public static class SimpleMailboxACLCommand implements MailboxACLCommand {
- private MailboxACLEntryKey key;
- private EditMode editMode;
- private MailboxACLRights rights;
+ private final MailboxACLEntryKey key;
+ private final EditMode editMode;
+ private final MailboxACLRights rights;
public SimpleMailboxACLCommand(MailboxACLEntryKey key, EditMode
editMode, MailboxACLRights rights) {
this.key = key;
Modified:
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/UpdatedFlags.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/UpdatedFlags.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/UpdatedFlags.java
(original)
+++
james/project/trunk/mailbox/api/src/main/java/org/apache/james/mailbox/model/UpdatedFlags.java
Tue Jan 26 10:22:12 2016
@@ -35,7 +35,7 @@ public class UpdatedFlags {
private final Flags oldFlags;
private final Flags newFlags;
private final Flags modifiedFlags;
- private long modSeq;
+ private final long modSeq;
public UpdatedFlags(long uid, long modSeq, Flags oldFlags, Flags newFlags)
{
this.uid = uid;
Modified:
james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/mock/MockMailboxManager.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/mock/MockMailboxManager.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/mock/MockMailboxManager.java
(original)
+++
james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/mock/MockMailboxManager.java
Tue Jan 26 10:22:12 2016
@@ -40,7 +40,7 @@ public class MockMailboxManager {
/**
* The mock mailbox manager constructed based on a provided mailboxmanager.
*/
- private MailboxManager mockMailboxManager;
+ private final MailboxManager mockMailboxManager;
/**
* Number of Domains to be created in the Mailbox Manager.
Modified:
james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/mock/MockMailboxSession.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/mock/MockMailboxSession.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/mock/MockMailboxSession.java
(original)
+++
james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/mock/MockMailboxSession.java
Tue Jan 26 10:22:12 2016
@@ -32,13 +32,13 @@ import org.slf4j.LoggerFactory;
public class MockMailboxSession implements MailboxSession{
- private User user;
+ private final User user;
private boolean close;
- private Map<Object, Object> attrs = new HashMap<Object, Object>();
- private Logger log = LoggerFactory.getLogger("MockLog");
+ private final Map<Object, Object> attrs = new HashMap<Object, Object>();
+ private final Logger log = LoggerFactory.getLogger("MockLog");
private final static Random RANDOM = new Random();
- private long sessionId = RANDOM.nextLong();
+ private final long sessionId = RANDOM.nextLong();
public MockMailboxSession(final String username) {
this.user = new User() {
Modified:
james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/util/EventCollector.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/util/EventCollector.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/util/EventCollector.java
(original)
+++
james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/util/EventCollector.java
Tue Jan 26 10:22:12 2016
@@ -28,7 +28,7 @@ public class EventCollector implements M
private final List<Event> events = new ArrayList<Event>();
- private ListenerType listenerType;
+ private final ListenerType listenerType;
public EventCollector(ListenerType listenerType) {
this.listenerType = listenerType;
Modified:
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CacheInvalidatingMailboxListener.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CacheInvalidatingMailboxListener.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CacheInvalidatingMailboxListener.java
(original)
+++
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CacheInvalidatingMailboxListener.java
Tue Jan 26 10:22:12 2016
@@ -11,8 +11,8 @@ import org.apache.james.mailbox.store.ma
*/
public class CacheInvalidatingMailboxListener<Id extends MailboxId> implements
MailboxListener {
- private MailboxByPathCache<Id> mailboxCacheByPath;
- private MailboxMetadataCache<Id> mailboxMetadataCache;
+ private final MailboxByPathCache<Id> mailboxCacheByPath;
+ private final MailboxMetadataCache<Id> mailboxMetadataCache;
public CacheInvalidatingMailboxListener(MailboxByPathCache<Id>
mailboxCacheByPath, MailboxMetadataCache<Id> mailboxMetadataCache) {
this.mailboxCacheByPath = mailboxCacheByPath;
Modified:
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMailboxMapper.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMailboxMapper.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMailboxMapper.java
(original)
+++
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMailboxMapper.java
Tue Jan 26 10:22:12 2016
@@ -18,8 +18,8 @@ import org.apache.james.mailbox.store.ma
public class CachingMailboxMapper<Id extends MailboxId> implements
MailboxMapper<Id> {
- private MailboxMapper<Id> underlying;
- private MailboxByPathCache<Id> cache;
+ private final MailboxMapper<Id> underlying;
+ private final MailboxByPathCache<Id> cache;
public CachingMailboxMapper(MailboxMapper<Id> underlying,
MailboxByPathCache<Id> cache) {
this.underlying = underlying;
Modified:
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMailboxSessionMapperFactory.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMailboxSessionMapperFactory.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMailboxSessionMapperFactory.java
(original)
+++
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMailboxSessionMapperFactory.java
Tue Jan 26 10:22:12 2016
@@ -19,9 +19,9 @@ import org.apache.james.mailbox.store.us
public class CachingMailboxSessionMapperFactory<Id extends MailboxId> extends
MailboxSessionMapperFactory<Id> {
- private MailboxSessionMapperFactory<Id> underlying;
- private MailboxByPathCache<Id> mailboxByPathCache;
- private MailboxMetadataCache<Id> mailboxMetadataCache;
+ private final MailboxSessionMapperFactory<Id> underlying;
+ private final MailboxByPathCache<Id> mailboxByPathCache;
+ private final MailboxMetadataCache<Id> mailboxMetadataCache;
public
CachingMailboxSessionMapperFactory(MailboxSessionMapperFactory<Id> underlying,
MailboxByPathCache<Id> mailboxByPathCache, MailboxMetadataCache<Id>
mailboxMetadataCache) {
this.underlying = underlying;
Modified:
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMessageMapper.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMessageMapper.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMessageMapper.java
(original)
+++
james/project/trunk/mailbox/caching/src/main/java/org/apache/james/mailbox/caching/CachingMessageMapper.java
Tue Jan 26 10:22:12 2016
@@ -21,8 +21,8 @@ import org.apache.james.mailbox.store.ma
*/
public class CachingMessageMapper<Id extends MailboxId> implements
MessageMapper<Id> {
- private MessageMapper<Id> underlying;
- private MailboxMetadataCache<Id> cache;
+ private final MessageMapper<Id> underlying;
+ private final MailboxMetadataCache<Id> cache;
public CachingMessageMapper(MessageMapper<Id> underlying,
MailboxMetadataCache<Id> cache) {
this.underlying = underlying;
Modified:
james/project/trunk/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/CassandraMailboxManager.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/CassandraMailboxManager.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/CassandraMailboxManager.java
(original)
+++
james/project/trunk/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/CassandraMailboxManager.java
Tue Jan 26 10:22:12 2016
@@ -41,7 +41,7 @@ import org.apache.james.mailbox.store.se
*/
@Singleton
public class CassandraMailboxManager extends StoreMailboxManager<CassandraId> {
- private MailboxPathLocker locker;
+ private final MailboxPathLocker locker;
@Inject
public CassandraMailboxManager(CassandraMailboxSessionMapperFactory
mapperFactory, Authenticator authenticator, final MailboxPathLocker locker) {
Modified:
james/project/trunk/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/user/CassandraSubscriptionMapper.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/user/CassandraSubscriptionMapper.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/user/CassandraSubscriptionMapper.java
(original)
+++
james/project/trunk/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/user/CassandraSubscriptionMapper.java
Tue Jan 26 10:22:12 2016
@@ -41,7 +41,7 @@ import com.datastax.driver.core.Session;
import com.datastax.driver.core.querybuilder.QueryBuilder;
public class CassandraSubscriptionMapper extends NonTransactionalMapper
implements SubscriptionMapper {
- private Session session;
+ private final Session session;
public CassandraSubscriptionMapper(Session session) {
this.session = session;
Modified:
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/IndexCreationFactory.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/IndexCreationFactory.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/IndexCreationFactory.java
(original)
+++
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/IndexCreationFactory.java
Tue Jan 26 10:22:12 2016
@@ -33,7 +33,7 @@ import java.util.Optional;
public class IndexCreationFactory {
- private static Logger LOGGER =
LoggerFactory.getLogger(IndexCreationFactory.class);
+ private static final Logger LOGGER =
LoggerFactory.getLogger(IndexCreationFactory.class);
public static ClientProvider createIndex(ClientProvider clientProvider,
int nbShards, int nbReplica) {
try {
Modified:
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/json/HeaderCollection.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/json/HeaderCollection.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/json/HeaderCollection.java
(original)
+++
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/json/HeaderCollection.java
Tue Jan 26 10:22:12 2016
@@ -195,7 +195,7 @@ public class HeaderCollection {
private final ImmutableSet<EMailer> replyToAddressSet;
private final ImmutableSet<String> subjectSet;
private final ImmutableMultimap<String, String> headers;
- private Optional<ZonedDateTime> sentDate;
+ private final Optional<ZonedDateTime> sentDate;
private HeaderCollection(ImmutableSet<EMailer> toAddressSet,
ImmutableSet<EMailer> fromAddressSet,
ImmutableSet<EMailer> ccAddressSet, ImmutableSet<EMailer>
bccAddressSet, ImmutableSet<EMailer> replyToAddressSet, ImmutableSet<String>
subjectSet,
Modified:
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/json/MimePart.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/json/MimePart.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/json/MimePart.java
(original)
+++
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/json/MimePart.java
Tue Jan 26 10:22:12 2016
@@ -42,9 +42,9 @@ public class MimePart {
public static class Builder implements MimePartContainerBuilder {
- private HeaderCollection.Builder headerCollectionBuilder;
+ private final HeaderCollection.Builder headerCollectionBuilder;
private Optional<InputStream> bodyContent;
- private List<MimePart> children;
+ private final List<MimePart> children;
private Optional<String> mediaType;
private Optional<String> subType;
private Optional<String> fileName;
Modified:
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/query/CriterionConverter.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/query/CriterionConverter.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/query/CriterionConverter.java
(original)
+++
james/project/trunk/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/query/CriterionConverter.java
Tue Jan 26 10:22:12 2016
@@ -43,8 +43,8 @@ import static org.elasticsearch.index.qu
public class CriterionConverter {
- private Map<Class<?>, Function<SearchQuery.Criterion,
FilteredQueryRepresentation>> criterionConverterMap;
- private Map<Class<?>, BiFunction<String, SearchQuery.HeaderOperator,
FilteredQueryRepresentation>> headerOperatorConverterMap;
+ private final Map<Class<?>, Function<SearchQuery.Criterion,
FilteredQueryRepresentation>> criterionConverterMap;
+ private final Map<Class<?>, BiFunction<String, SearchQuery.HeaderOperator,
FilteredQueryRepresentation>> headerOperatorConverterMap;
public CriterionConverter() {
criterionConverterMap = new HashMap<>();
Modified:
james/project/trunk/mailbox/elasticsearch/src/test/java/org/apache/james/mailbox/elasticsearch/EmbeddedElasticSearch.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/elasticsearch/src/test/java/org/apache/james/mailbox/elasticsearch/EmbeddedElasticSearch.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/elasticsearch/src/test/java/org/apache/james/mailbox/elasticsearch/EmbeddedElasticSearch.java
(original)
+++
james/project/trunk/mailbox/elasticsearch/src/test/java/org/apache/james/mailbox/elasticsearch/EmbeddedElasticSearch.java
Tue Jan 26 10:22:12 2016
@@ -41,7 +41,7 @@ import com.jayway.awaitility.Duration;
public class EmbeddedElasticSearch extends ExternalResource {
- private static Logger LOGGER =
LoggerFactory.getLogger(EmbeddedElasticSearch.class);
+ private static final Logger LOGGER =
LoggerFactory.getLogger(EmbeddedElasticSearch.class);
private final Supplier<Path> folder;
private Node node;
Modified:
james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/io/ChunkOutputStream.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/io/ChunkOutputStream.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/io/ChunkOutputStream.java
(original)
+++
james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/io/ChunkOutputStream.java
Tue Jan 26 10:22:12 2016
@@ -41,7 +41,7 @@ public class ChunkOutputStream extends O
private final byte[] tableName;
private final byte[] cf;
private final byte[] key;
- private byte[] chunk;
+ private final byte[] chunk;
private long chunkPos = 1;
private long pos = 0;
Modified:
james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/HBaseMailboxMessage.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/HBaseMailboxMessage.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/HBaseMailboxMessage.java
(original)
+++
james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/HBaseMailboxMessage.java
Tue Jan 26 10:22:12 2016
@@ -57,13 +57,13 @@ public class HBaseMailboxMessage impleme
/** Configuration for the HBase cluster */
private final Configuration conf;
/** The value for the mailboxId field */
- private HBaseId mailboxId;
+ private final HBaseId mailboxId;
/** The value for the uid field */
private long uid;
/** The value for the modSeq field */
private long modSeq;
/** The value for the internalDate field */
- private Date internalDate;
+ private final Date internalDate;
/** The value for the answered field */
private boolean answered = false;
/** The value for the deleted field */
@@ -77,18 +77,18 @@ public class HBaseMailboxMessage impleme
/** The value for the seen field */
private boolean seen = false;
/** The first body octet */
- private int bodyStartOctet;
+ private final int bodyStartOctet;
/** Number of octets in the full document content */
- private long contentOctets;
+ private final long contentOctets;
/** MIME media type */
- private String mediaType;
+ private final String mediaType;
/** MIME sub type */
- private String subType;
+ private final String subType;
/** THE CRFL count when this document is textual, null otherwise */
private Long textualLineCount;
/** Meta data for this message */
- private List<Property> properties;
- private List<String> userFlags;
+ private final List<Property> properties;
+ private final List<String> userFlags;
/**
* Create a copy of the given message.
Modified:
james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/model/HBaseMailbox.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/model/HBaseMailbox.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/model/HBaseMailbox.java
(original)
+++
james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/model/HBaseMailbox.java
Tue Jan 26 10:22:12 2016
@@ -39,7 +39,7 @@ public class HBaseMailbox implements Mai
/** The value for the name field */
private String name;
/** The value for the uidValidity field */
- private long uidValidity;
+ private final long uidValidity;
private String user;
private String namespace;
private long lastUid;
Modified:
james/project/trunk/mailbox/hbase/src/test/java/org/apache/james/mailbox/hbase/mail/HBaseMailboxMessageMapperTest.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/hbase/src/test/java/org/apache/james/mailbox/hbase/mail/HBaseMailboxMessageMapperTest.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/hbase/src/test/java/org/apache/james/mailbox/hbase/mail/HBaseMailboxMessageMapperTest.java
(original)
+++
james/project/trunk/mailbox/hbase/src/test/java/org/apache/james/mailbox/hbase/mail/HBaseMailboxMessageMapperTest.java
Tue Jan 26 10:22:12 2016
@@ -88,7 +88,7 @@ public class HBaseMailboxMessageMapperTe
+ "\n"
+ "Test\n"
+ "\n.");
- private static SharedInputStream content = new
SharedByteArrayInputStream(messageTemplate);
+ private static final SharedInputStream content = new
SharedByteArrayInputStream(messageTemplate);
@Before
public void setUp() throws Exception {
Modified:
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/AbstractJCRScalingMapper.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/AbstractJCRScalingMapper.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/AbstractJCRScalingMapper.java
(original)
+++
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/AbstractJCRScalingMapper.java
Tue Jan 26 10:22:12 2016
@@ -40,7 +40,7 @@ public abstract class AbstractJCRScaling
private final MailboxSessionJCRRepository repository;
private final int scaling;
- private MailboxSession mSession;
+ private final MailboxSession mSession;
private final static char PAD ='_';
public AbstractJCRScalingMapper(MailboxSessionJCRRepository repository,
MailboxSession mSession, int scaling) {
Modified:
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/GlobalMailboxSessionJCRRepository.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/GlobalMailboxSessionJCRRepository.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/GlobalMailboxSessionJCRRepository.java
(original)
+++
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/GlobalMailboxSessionJCRRepository.java
Tue Jan 26 10:22:12 2016
@@ -32,8 +32,8 @@ import org.apache.james.mailbox.MailboxS
*/
public class GlobalMailboxSessionJCRRepository extends
MailboxSessionJCRRepository{
- private String username;
- private char[] pass;
+ private final String username;
+ private final char[] pass;
public GlobalMailboxSessionJCRRepository(Repository repository, String
workspace, String username, String password) {
super(repository, workspace);
Modified:
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/JCRMailboxSessionMapperFactory.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/JCRMailboxSessionMapperFactory.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/JCRMailboxSessionMapperFactory.java
(original)
+++
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/JCRMailboxSessionMapperFactory.java
Tue Jan 26 10:22:12 2016
@@ -41,9 +41,9 @@ public class JCRMailboxSessionMapperFact
private final MailboxSessionJCRRepository repository;
private final static int DEFAULT_SCALING = 2;
private final int scaling;
- private int messageScaling;
- private UidProvider<JCRId> uidProvider;
- private ModSeqProvider<JCRId> modSeqProvider;
+ private final int messageScaling;
+ private final UidProvider<JCRId> uidProvider;
+ private final ModSeqProvider<JCRId> modSeqProvider;
public JCRMailboxSessionMapperFactory(final MailboxSessionJCRRepository
repository, final UidProvider<JCRId> uidProvider, final ModSeqProvider<JCRId>
modSeqProvider) {
this(repository, uidProvider, modSeqProvider, DEFAULT_SCALING,
JCRMessageMapper.MESSAGE_SCALE_DAY);
Modified:
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/JCRRepositoryAuthenticator.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/JCRRepositoryAuthenticator.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/JCRRepositoryAuthenticator.java
(original)
+++
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/JCRRepositoryAuthenticator.java
Tue Jan 26 10:22:12 2016
@@ -35,7 +35,7 @@ import org.apache.james.mailbox.store.Au
*/
public class JCRRepositoryAuthenticator implements Authenticator{
- private MailboxSessionJCRRepository repository;
+ private final MailboxSessionJCRRepository repository;
public JCRRepositoryAuthenticator(MailboxSessionJCRRepository repository) {
this.repository = repository;
Modified:
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/MailboxSessionJCRRepository.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/MailboxSessionJCRRepository.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/MailboxSessionJCRRepository.java
(original)
+++
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/MailboxSessionJCRRepository.java
Tue Jan 26 10:22:12 2016
@@ -33,8 +33,8 @@ import org.apache.james.mailbox.MailboxS
*/
public class MailboxSessionJCRRepository {
private final static String JCR_SESSION = "JCR_SESSION";
- private Repository repository;
- private String workspace;
+ private final Repository repository;
+ private final String workspace;
public MailboxSessionJCRRepository(Repository repository ,String
workspace) {
this.repository = repository;
Modified:
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRModSeqProvider.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRModSeqProvider.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRModSeqProvider.java
(original)
+++
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRModSeqProvider.java
Tue Jan 26 10:22:12 2016
@@ -33,7 +33,7 @@ import org.apache.james.mailbox.store.ma
public class JCRModSeqProvider extends AbstractLockingModSeqProvider<JCRId>{
- private MailboxSessionJCRRepository repository;
+ private final MailboxSessionJCRRepository repository;
public JCRModSeqProvider(MailboxPathLocker locker,
MailboxSessionJCRRepository repository) {
super(locker);
Modified:
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRUidProvider.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRUidProvider.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRUidProvider.java
(original)
+++
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRUidProvider.java
Tue Jan 26 10:22:12 2016
@@ -33,7 +33,7 @@ import org.apache.james.mailbox.store.ma
public class JCRUidProvider extends AbstractLockingUidProvider<JCRId> {
- private MailboxSessionJCRRepository repository;
+ private final MailboxSessionJCRRepository repository;
public JCRUidProvider(MailboxPathLocker locker,
MailboxSessionJCRRepository repository) {
super(locker);
Modified:
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/user/model/JCRSubscription.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/user/model/JCRSubscription.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/user/model/JCRSubscription.java
(original)
+++
james/project/trunk/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/user/model/JCRSubscription.java
Tue Jan 26 10:22:12 2016
@@ -43,7 +43,7 @@ public class JCRSubscription implements
private Node node;
private final Logger log;
- private String mailbox;
+ private final String mailbox;
private String username;
Modified:
james/project/trunk/mailbox/jcr/src/test/java/org/apache/james/mailbox/jcr/JCRSubscriptionManagerTest.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jcr/src/test/java/org/apache/james/mailbox/jcr/JCRSubscriptionManagerTest.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jcr/src/test/java/org/apache/james/mailbox/jcr/JCRSubscriptionManagerTest.java
(original)
+++
james/project/trunk/mailbox/jcr/src/test/java/org/apache/james/mailbox/jcr/JCRSubscriptionManagerTest.java
Tue Jan 26 10:22:12 2016
@@ -38,9 +38,9 @@ public class JCRSubscriptionManagerTest
public static final String META_DATA_DIRECTORY = "target/user-meta-data";
private static RepositoryImpl repository;
- private static String user = "user";
- private static String pass = "pass";
- private static String workspace = null;
+ private static final String user = "user";
+ private static final String pass = "pass";
+ private static final String workspace = null;
@BeforeClass
public static void before() throws RepositoryException {
Modified:
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAModSeqProvider.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAModSeqProvider.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAModSeqProvider.java
(original)
+++
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAModSeqProvider.java
Tue Jan 26 10:22:12 2016
@@ -32,7 +32,7 @@ import org.apache.james.mailbox.store.ma
public class JPAModSeqProvider extends AbstractLockingModSeqProvider<JPAId> {
- private EntityManagerFactory factory;
+ private final EntityManagerFactory factory;
public JPAModSeqProvider(MailboxPathLocker locker, EntityManagerFactory
factory) {
super(locker);
Modified:
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAUidProvider.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAUidProvider.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAUidProvider.java
(original)
+++
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAUidProvider.java
Tue Jan 26 10:22:12 2016
@@ -32,7 +32,7 @@ import org.apache.james.mailbox.store.ma
public class JPAUidProvider extends AbstractLockingUidProvider<JPAId> {
- private EntityManagerFactory factory;
+ private final EntityManagerFactory factory;
public JPAUidProvider(MailboxPathLocker locker, EntityManagerFactory
factory) {
super(locker);
Modified:
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/AbstractJPAMailboxMessage.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/AbstractJPAMailboxMessage.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/AbstractJPAMailboxMessage.java
(original)
+++
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/AbstractJPAMailboxMessage.java
Tue Jan 26 10:22:12 2016
@@ -175,7 +175,7 @@ public abstract class AbstractJPAMailbox
/** The value for the internalDate field */
@Basic(optional = false)
@Column(name = "MAIL_DATE")
- private Date internalDate;
+ private final Date internalDate;
/** The value for the answered field */
@Basic(optional = false)
@@ -214,27 +214,27 @@ public abstract class AbstractJPAMailbox
/** The first body octet */
@Basic(optional = false)
@Column(name = "MAIL_BODY_START_OCTET", nullable = false)
- private int bodyStartOctet;
+ private final int bodyStartOctet;
/** Number of octets in the full document content */
@Basic(optional = false)
@Column(name = "MAIL_CONTENT_OCTETS_COUNT", nullable = false)
- private long contentOctets;
+ private final long contentOctets;
/** MIME media type */
@Basic(optional = true)
@Column(name = "MAIL_MIME_TYPE", nullable = true, length = 200)
- private String mediaType;
+ private final String mediaType;
/** MIME sub type */
@Basic(optional = true)
@Column(name = "MAIL_MIME_SUBTYPE", nullable = true, length = 200)
- private String subType;
+ private final String subType;
/** THE CRFL count when this document is textual, null otherwise */
@Basic(optional = true)
@Column(name = "MAIL_TEXTUAL_LINE_COUNT", nullable = true)
- private Long textualLineCount;
+ private final Long textualLineCount;
/** Meta data for this message */
@@ -242,13 +242,13 @@ public abstract class AbstractJPAMailbox
@OrderBy("line")
@ElementJoinColumns({@ElementJoinColumn(name="MAILBOX_ID",
referencedColumnName="MAILBOX_ID"),
@ElementJoinColumn(name="MAIL_UID",
referencedColumnName="MAIL_UID")})
- private List<JPAProperty> properties;
+ private final List<JPAProperty> properties;
@OneToMany(cascade = CascadeType.ALL, fetch=FetchType.EAGER, orphanRemoval
= true)
@OrderBy("id")
@ElementJoinColumns({@ElementJoinColumn(name="MAILBOX_ID",
referencedColumnName="MAILBOX_ID"),
@ElementJoinColumn(name="MAIL_UID", referencedColumnName="MAIL_UID")})
- private List<JPAUserFlag> userFlags;
+ private final List<JPAUserFlag> userFlags;
public AbstractJPAMailboxMessage(JPAMailbox mailbox, Date internalDate,
Flags flags, final long contentOctets, final int bodyStartOctet, final
PropertyBuilder propertyBuilder) {
this.mailbox = mailbox;
Modified:
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/EncryptDecryptHelper.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/EncryptDecryptHelper.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/EncryptDecryptHelper.java
(original)
+++
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/EncryptDecryptHelper.java
Tue Jan 26 10:22:12 2016
@@ -28,7 +28,7 @@ import org.jasypt.encryption.pbe.Standar
public class EncryptDecryptHelper {
// Use one static instance as it is thread safe
- private static StandardPBEByteEncryptor encryptor = new
StandardPBEByteEncryptor();
+ private static final StandardPBEByteEncryptor encryptor = new
StandardPBEByteEncryptor();
/**
Modified:
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAEncryptedMailboxMessage.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAEncryptedMailboxMessage.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAEncryptedMailboxMessage.java
(original)
+++
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAEncryptedMailboxMessage.java
Tue Jan 26 10:22:12 2016
@@ -50,7 +50,7 @@ public class JPAEncryptedMailboxMessage
@Column(name = "MAIL_BYTES", length = 1048576000, nullable = false)
@Externalizer("EncryptDecryptHelper.getEncrypted")
@Factory("EncryptDecryptHelper.getDecrypted")
- @Lob private byte[] body;
+ @Lob private final byte[] body;
/** The value for the header field. Lazy loaded */
@@ -59,7 +59,7 @@ public class JPAEncryptedMailboxMessage
@Column(name = "HEADER_BYTES", length = 10485760, nullable = false)
@Externalizer("EncryptDecryptHelper.getEncrypted")
@Factory("EncryptDecryptHelper.getDecrypted")
- @Lob private byte[] header;
+ @Lob private final byte[] header;
public JPAEncryptedMailboxMessage(JPAMailbox mailbox, Date
internalDate, int size, Flags flags, SharedInputStream content, int
bodyStartOctet, final PropertyBuilder propertyBuilder) throws MailboxException {
super(mailbox, internalDate, flags, size ,bodyStartOctet,
propertyBuilder);
Modified:
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAMailboxMessage.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAMailboxMessage.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAMailboxMessage.java
(original)
+++
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAMailboxMessage.java
Tue Jan 26 10:22:12 2016
@@ -46,14 +46,14 @@ public class JPAMailboxMessage extends A
/** We use a max length to represent 1gb data. Thats prolly overkill, but
who knows */
@Basic(optional = false, fetch = FetchType.LAZY)
@Column(name = "MAIL_BYTES", length = 1048576000, nullable = false)
- @Lob private byte[] body;
+ @Lob private final byte[] body;
/** The value for the header field. Lazy loaded */
/** We use a max length to represent 10mb data. Thats prolly overkill, but
who knows */
@Basic(optional = false, fetch = FetchType.LAZY)
@Column(name = "HEADER_BYTES", length = 10485760, nullable = false)
- @Lob private byte[] header;
+ @Lob private final byte[] header;
public JPAMailboxMessage(JPAMailbox mailbox, Date internalDate, int size,
Flags flags, SharedInputStream content, int bodyStartOctet, final
PropertyBuilder propertyBuilder) throws MailboxException {
super(mailbox, internalDate, flags, size ,bodyStartOctet,
propertyBuilder);
Modified:
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAStreamingMailboxMessage.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAStreamingMailboxMessage.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAStreamingMailboxMessage.java
(original)
+++
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/JPAStreamingMailboxMessage.java
Tue Jan 26 10:22:12 2016
@@ -53,13 +53,13 @@ public class JPAStreamingMailboxMessage
@Persistent(optional = false, fetch = FetchType.LAZY)
@Column(name = "MAIL_BYTES", length = 1048576000, nullable = false)
- private InputStream body;
+ private final InputStream body;
@Persistent(optional = false, fetch = FetchType.LAZY)
@Column(name = "HEADER_BYTES", length = 10485760, nullable = false)
- private InputStream header;
+ private final InputStream header;
- private SharedInputStream content;
+ private final SharedInputStream content;
public JPAStreamingMailboxMessage(JPAMailbox mailbox, Date internalDate,
int size, Flags flags, SharedInputStream content, int bodyStartOctet, final
PropertyBuilder propertyBuilder) throws MailboxException {
super(mailbox, internalDate, flags, size ,bodyStartOctet,
propertyBuilder);
Modified:
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/openjpa/OpenJPAMailboxManager.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/openjpa/OpenJPAMailboxManager.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/openjpa/OpenJPAMailboxManager.java
(original)
+++
james/project/trunk/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/openjpa/OpenJPAMailboxManager.java
Tue Jan 26 10:22:12 2016
@@ -41,7 +41,7 @@ import org.apache.james.mailbox.store.ma
*/
public class OpenJPAMailboxManager extends JPAMailboxManager {
- private AdvancedFeature feature;
+ private final AdvancedFeature feature;
public OpenJPAMailboxManager(JPAMailboxSessionMapperFactory mapperFactory,
Authenticator authenticator, MailboxPathLocker locker, boolean useStreaming,
MailboxACLResolver aclResolver, GroupMembershipResolver
groupMembershipResolver) {
super(mapperFactory, authenticator, locker, aclResolver,
groupMembershipResolver);
Modified:
james/project/trunk/mailbox/kafka/src/main/java/org/apache/james/mailbox/kafka/KafkaMessageConsumer.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/kafka/src/main/java/org/apache/james/mailbox/kafka/KafkaMessageConsumer.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/kafka/src/main/java/org/apache/james/mailbox/kafka/KafkaMessageConsumer.java
(original)
+++
james/project/trunk/mailbox/kafka/src/main/java/org/apache/james/mailbox/kafka/KafkaMessageConsumer.java
Tue Jan 26 10:22:12 2016
@@ -42,7 +42,7 @@ public class KafkaMessageConsumer implem
private class Consumer implements Runnable {
- private KafkaStream<byte[], byte[]> m_stream;
+ private final KafkaStream<byte[], byte[]> m_stream;
public Consumer(KafkaStream<byte[], byte[]> a_stream) {
m_stream = a_stream;
Modified:
james/project/trunk/mailbox/lucene/src/main/java/org/apache/james/mailbox/lucene/search/UpperCaseFilter.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/lucene/src/main/java/org/apache/james/mailbox/lucene/search/UpperCaseFilter.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/lucene/src/main/java/org/apache/james/mailbox/lucene/search/UpperCaseFilter.java
(original)
+++
james/project/trunk/mailbox/lucene/src/main/java/org/apache/james/mailbox/lucene/search/UpperCaseFilter.java
Tue Jan 26 10:22:12 2016
@@ -28,7 +28,7 @@ import org.apache.lucene.analysis.tokena
* Normalizes token text to upper case.
*/
public final class UpperCaseFilter extends TokenFilter {
- private CharTermAttribute termAtt;
+ private final CharTermAttribute termAtt;
public UpperCaseFilter(TokenStream in) {
super(in);
Modified:
james/project/trunk/mailbox/lucene/src/test/java/org/apache/james/mailbox/lucene/search/LuceneMailboxMessageSearchIndexTest.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/lucene/src/test/java/org/apache/james/mailbox/lucene/search/LuceneMailboxMessageSearchIndexTest.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/lucene/src/test/java/org/apache/james/mailbox/lucene/search/LuceneMailboxMessageSearchIndexTest.java
(original)
+++
james/project/trunk/mailbox/lucene/src/test/java/org/apache/james/mailbox/lucene/search/LuceneMailboxMessageSearchIndexTest.java
Tue Jan 26 10:22:12 2016
@@ -703,7 +703,7 @@ public class LuceneMailboxMessageSearchI
}
private final class SimpleMailbox implements Mailbox<TestId> {
- private TestId id;
+ private final TestId id;
public SimpleMailbox(long id) {
this.id = TestId.of(id);
Modified:
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirFolder.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirFolder.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirFolder.java
(original)
+++
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirFolder.java
Tue Jan 26 10:22:12 2016
@@ -62,12 +62,12 @@ public class MaildirFolder {
public static final String NEW = "new";
public static final String TMP = "tmp";
- private File rootFolder;
- private File curFolder;
- private File newFolder;
- private File tmpFolder;
- private File uidFile;
- private File aclFile;
+ private final File rootFolder;
+ private final File curFolder;
+ private final File newFolder;
+ private final File tmpFolder;
+ private final File uidFile;
+ private final File aclFile;
private long lastUid = -1;
private int messageCount = 0;
Modified:
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirMessageName.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirMessageName.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirMessageName.java
(original)
+++
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirMessageName.java
Tue Jan 26 10:22:12 2016
@@ -61,12 +61,12 @@ public class MaildirMessageName {
/**
* The number of deliveries done by the server since its last start
*/
- private static AtomicInteger deliveries = new AtomicInteger(0);
+ private static final AtomicInteger deliveries = new AtomicInteger(0);
/**
* A random generator for the random part in the unique message names
*/
- private static Random random = new Random();
+ private static final Random random = new Random();
/**
* The process id of the server process
@@ -92,7 +92,7 @@ public class MaildirMessageName {
private String fullName;
private File file;
- private MaildirFolder parentFolder;
+ private final MaildirFolder parentFolder;
private String timestamp;
private String uniqueString;
private String hostnameAndMeta; // tim-erwin.de,S=1000:2,RS
Modified:
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirStore.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirStore.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirStore.java
(original)
+++
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirStore.java
Tue Jan 26 10:22:12 2016
@@ -43,7 +43,7 @@ public class MaildirStore implements Uid
public static final String maildirDelimiter = ".";
- private String maildirLocation;
+ private final String maildirLocation;
private File maildirRootFile;
private final MailboxPathLocker locker;
Modified:
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/UidConstraint.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/UidConstraint.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/UidConstraint.java
(original)
+++
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/UidConstraint.java
Tue Jan 26 10:22:12 2016
@@ -22,7 +22,7 @@ import java.util.LinkedList;
public class UidConstraint {
- private LinkedList<Constraint> constraints = new LinkedList<Constraint>();
+ private final LinkedList<Constraint> constraints = new
LinkedList<Constraint>();
public UidConstraint append(Constraint constraint) {
constraints.add(constraint);
@@ -64,7 +64,7 @@ public class UidConstraint {
public static class Equals extends Constraint {
- private long uid;
+ private final long uid;
public Equals(long uid) {
this.uid = uid;
@@ -79,7 +79,7 @@ public class UidConstraint {
public static class LessOrEquals extends Constraint {
- private long uid;
+ private final long uid;
public LessOrEquals(long uid) {
this.uid = uid;
@@ -94,7 +94,7 @@ public class UidConstraint {
public static class GreaterOrEquals extends Constraint {
- private long uid;
+ private final long uid;
public GreaterOrEquals(long uid) {
this.uid = uid;
@@ -109,8 +109,8 @@ public class UidConstraint {
public static class Between extends Constraint {
- private long lower;
- private long upper;
+ private final long lower;
+ private final long upper;
public Between(long lower, long upper) {
this.lower = lower;
Modified:
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMailboxMapper.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMailboxMapper.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMailboxMapper.java
(original)
+++
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMailboxMapper.java
Tue Jan 26 10:22:12 2016
@@ -53,7 +53,7 @@ public class MaildirMailboxMapper extend
/**
* A request-scoped list of mailboxes in order to refer to them via id
*/
- private ArrayList<Mailbox<MaildirId>> mailboxCache = new
ArrayList<Mailbox<MaildirId>>();
+ private final ArrayList<Mailbox<MaildirId>> mailboxCache = new
ArrayList<Mailbox<MaildirId>>();
private final MailboxSession session;
Modified:
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMailboxMessage.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMailboxMessage.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMailboxMessage.java
(original)
+++
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMailboxMessage.java
Tue Jan 26 10:22:12 2016
@@ -38,7 +38,7 @@ public class MaildirMailboxMessage exten
private boolean flagged;
private boolean recent;
private boolean seen;
- private Mailbox<MaildirId> mailbox;
+ private final Mailbox<MaildirId> mailbox;
private long uid;
protected boolean newMessage;
private long modSeq;
Modified:
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java
(original)
+++
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java
Tue Jan 26 10:22:12 2016
@@ -45,7 +45,7 @@ import java.util.List;
public class MaildirMessage implements Message {
- private MaildirMessageName messageName;
+ private final MaildirMessageName messageName;
private int bodyStartOctet;
private final PropertyBuilder propertyBuilder = new PropertyBuilder();
private boolean parsed;
Modified:
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/user/MaildirSubscriptionMapper.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/user/MaildirSubscriptionMapper.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/user/MaildirSubscriptionMapper.java
(original)
+++
james/project/trunk/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/user/MaildirSubscriptionMapper.java
Tue Jan 26 10:22:12 2016
@@ -40,7 +40,7 @@ import org.apache.james.mailbox.store.us
public class MaildirSubscriptionMapper extends NonTransactionalMapper
implements SubscriptionMapper {
private static final String FILE_SUBSCRIPTION = "subscriptions";
- private MaildirStore store;
+ private final MaildirStore store;
public MaildirSubscriptionMapper(MaildirStore store) {
this.store = store;
Modified:
james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/InMemoryMailboxSessionMapperFactory.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/InMemoryMailboxSessionMapperFactory.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/InMemoryMailboxSessionMapperFactory.java
(original)
+++
james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/InMemoryMailboxSessionMapperFactory.java
Tue Jan 26 10:22:12 2016
@@ -33,9 +33,9 @@ import org.apache.james.mailbox.store.us
public class InMemoryMailboxSessionMapperFactory extends
MailboxSessionMapperFactory<InMemoryId> {
- private MailboxMapper<InMemoryId> mailboxMapper;
- private MessageMapper<InMemoryId> messageMapper;
- private SubscriptionMapper subscriptionMapper;
+ private final MailboxMapper<InMemoryId> mailboxMapper;
+ private final MessageMapper<InMemoryId> messageMapper;
+ private final SubscriptionMapper subscriptionMapper;
public InMemoryMailboxSessionMapperFactory() {
mailboxMapper = new InMemoryMailboxMapper();
Modified:
james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/InMemoryMessageMapper.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/InMemoryMessageMapper.java?rev=1726759&r1=1726758&r2=1726759&view=diff
==============================================================================
---
james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/InMemoryMessageMapper.java
(original)
+++
james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/InMemoryMessageMapper.java
Tue Jan 26 10:22:12 2016
@@ -45,7 +45,7 @@ import org.apache.james.mailbox.store.ma
public class InMemoryMessageMapper extends AbstractMessageMapper<InMemoryId> {
- private Map<InMemoryId, Map<Long, MailboxMessage<InMemoryId>>>
mailboxByUid;
+ private final Map<InMemoryId, Map<Long, MailboxMessage<InMemoryId>>>
mailboxByUid;
private static final int INITIAL_SIZE = 256;
public InMemoryMessageMapper(MailboxSession session,
UidProvider<InMemoryId> uidProvider,
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
