Modified: james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/processor/base/MailboxEventAnalyserTest.java URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/processor/base/MailboxEventAnalyserTest.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/processor/base/MailboxEventAnalyserTest.java (original) +++ james/project/trunk/protocols/imap/src/test/java/org/apache/james/imap/processor/base/MailboxEventAnalyserTest.java Tue Jan 26 10:22:12 2016 @@ -354,7 +354,7 @@ public class MailboxEventAnalyserTest { }; private final class MyMailboxSession implements MailboxSession { - private long sessionId; + private final long sessionId; public MyMailboxSession(long sessionId) { this.sessionId = sessionId; @@ -410,7 +410,7 @@ public class MailboxEventAnalyserTest { } private class MyImapSession implements ImapSession{ - private MailboxSession mSession; + private final MailboxSession mSession; public MyImapSession(MailboxSession mSession) { this.mSession = mSession;
Modified: james/project/trunk/protocols/netty/src/main/java/org/apache/james/protocols/netty/ChannelGroupHandler.java URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/netty/src/main/java/org/apache/james/protocols/netty/ChannelGroupHandler.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/protocols/netty/src/main/java/org/apache/james/protocols/netty/ChannelGroupHandler.java (original) +++ james/project/trunk/protocols/netty/src/main/java/org/apache/james/protocols/netty/ChannelGroupHandler.java Tue Jan 26 10:22:12 2016 @@ -31,7 +31,7 @@ import org.jboss.netty.channel.group.Cha * */ public final class ChannelGroupHandler extends SimpleChannelUpstreamHandler { - private ChannelGroup channels; + private final ChannelGroup channels; public ChannelGroupHandler(ChannelGroup channels) { this.channels = channels; } Modified: james/project/trunk/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/core/TopCmdHandler.java URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/core/TopCmdHandler.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/core/TopCmdHandler.java (original) +++ james/project/trunk/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/core/TopCmdHandler.java Tue Jan 26 10:22:12 2016 @@ -143,7 +143,7 @@ public class TopCmdHandler extends RetrC private int count = 0; private int limit = -1; private int lastChar; - private InputStream in; + private final InputStream in; private boolean isBody = false; // starting from header private boolean isEmptyLine = false; Modified: james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPConfigurationImpl.java URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPConfigurationImpl.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPConfigurationImpl.java (original) +++ james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPConfigurationImpl.java Tue Jan 26 10:22:12 2016 @@ -31,7 +31,7 @@ import org.apache.james.protocols.api.Pr public class SMTPConfigurationImpl extends ProtocolConfigurationImpl implements SMTPConfiguration{ public String helloName = "localhost"; - private long maxMessageSize = 0; + private final long maxMessageSize = 0; private boolean bracketsEnforcement = true; private boolean enforceHeloEhlo = true; Modified: james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java (original) +++ james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java Tue Jan 26 10:22:12 2016 @@ -26,8 +26,8 @@ import java.util.Collections; import java.util.LinkedList; import java.util.List; -import org.apache.commons.configuration.Configuration; -import org.apache.commons.configuration.ConfigurationException; +import org.apache.commons.configuration.Configuration; +import org.apache.commons.configuration.ConfigurationException; import org.apache.james.protocols.api.ProtocolSession; import org.apache.james.protocols.api.Request; import org.apache.james.protocols.api.Response; @@ -64,22 +64,22 @@ public class DataCmdHandler implements C } return null; } - - @Override - public void init(Configuration config) throws ConfigurationException { - - } - - @Override - public void destroy() { - - } + + @Override + public void init(Configuration config) throws ConfigurationException { + + } + + @Override + public void destroy() { + + } } public static final class DataLineFilterWrapper implements LineHandler<SMTPSession> { - private DataLineFilter filter; - private LineHandler<SMTPSession> next; + private final DataLineFilter filter; + private final LineHandler<SMTPSession> next; public DataLineFilterWrapper(DataLineFilter filter, LineHandler<SMTPSession> next) { this.filter = filter; @@ -96,32 +96,32 @@ public class DataCmdHandler implements C Response r = filter.onLine(session, line, next); return r; } - - @Override - public void init(Configuration config) throws ConfigurationException { - - } - - @Override - public void destroy() { - - } + + @Override + public void init(Configuration config) throws ConfigurationException { + + } + + @Override + public void destroy() { + + } } public final static String MAILENV = "MAILENV"; private LineHandler<SMTPSession> lineHandler; - - @Override - public void init(Configuration config) throws ConfigurationException { - - } - - @Override - public void destroy() { - - } - + + @Override + public void init(Configuration config) throws ConfigurationException { + + } + + @Override + public void destroy() { + + } + /** * process DATA command * Modified: james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/DNSRBLHandler.java URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/DNSRBLHandler.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/DNSRBLHandler.java (original) +++ james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/DNSRBLHandler.java Tue Jan 26 10:22:12 2016 @@ -47,7 +47,7 @@ public class DNSRBLHandler implements Rc private boolean getDetail = false; - private String blocklistedDetail = null; + private final String blocklistedDetail = null; public static final String RBL_BLOCKLISTED_MAIL_ATTRIBUTE_NAME = "org.apache.james.smtpserver.rbl.blocklisted"; Modified: james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java (original) +++ james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java Tue Jan 26 10:22:12 2016 @@ -39,7 +39,7 @@ import org.apache.james.protocols.smtp.h public class SpamTrapHandler implements RcptHook { /** Map which hold blockedIps and blockTime in memory */ - private Map<String,Long> blockedIps = new HashMap<String,Long>(); + private final Map<String,Long> blockedIps = new HashMap<String,Long>(); private Collection<String> spamTrapRecips = new ArrayList<String>(); Modified: james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/hook/HookResult.java URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/hook/HookResult.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/hook/HookResult.java (original) +++ james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/hook/HookResult.java Tue Jan 26 10:22:12 2016 @@ -31,9 +31,9 @@ public final class HookResult { private static final HookResult DENYSOFT = new HookResult(HookReturnCode.DENYSOFT); private static final HookResult DISCONNECT = new HookResult(HookReturnCode.DISCONNECT); - private int result; - private String smtpRetCode; - private String smtpDescription; + private final int result; + private final String smtpRetCode; + private final String smtpDescription; /** * Construct new HookResult Modified: james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/modules/server/ActiveMQQueueModule.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/modules/server/ActiveMQQueueModule.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/modules/server/ActiveMQQueueModule.java (original) +++ james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/modules/server/ActiveMQQueueModule.java Tue Jan 26 10:22:12 2016 @@ -31,7 +31,7 @@ import javax.jms.ConnectionFactory; public class ActiveMQQueueModule extends AbstractModule { - private static Logger LOGGER = LoggerFactory.getLogger(ActiveMQQueueModule.class); + private static final Logger LOGGER = LoggerFactory.getLogger(ActiveMQQueueModule.class); @Override protected void configure() { Modified: james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/modules/server/EmbeddedActiveMQ.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/modules/server/EmbeddedActiveMQ.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/modules/server/EmbeddedActiveMQ.java (original) +++ james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/modules/server/EmbeddedActiveMQ.java Tue Jan 26 10:22:12 2016 @@ -40,7 +40,7 @@ import com.google.inject.Singleton; @Singleton public class EmbeddedActiveMQ { - private ActiveMQConnectionFactory activeMQConnectionFactory; + private final ActiveMQConnectionFactory activeMQConnectionFactory; private BrokerService brokerService; @Inject private EmbeddedActiveMQ(FileSystem fileSystem) { Modified: james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/GuiceMailboxManagerResolver.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/GuiceMailboxManagerResolver.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/GuiceMailboxManagerResolver.java (original) +++ james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/GuiceMailboxManagerResolver.java Tue Jan 26 10:22:12 2016 @@ -33,7 +33,7 @@ import com.google.inject.Inject; public class GuiceMailboxManagerResolver implements MailboxManagerResolver { - private ImmutableMap<String, MailboxManager> managers; + private final ImmutableMap<String, MailboxManager> managers; @Inject private GuiceMailboxManagerResolver(Set<MailboxManagerDefinition> managers) { Modified: james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/GuiceServerProbe.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/GuiceServerProbe.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/GuiceServerProbe.java (original) +++ james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/GuiceServerProbe.java Tue Jan 26 10:22:12 2016 @@ -55,9 +55,9 @@ public class GuiceServerProbe implements private static final Logger LOGGER = LoggerFactory.getLogger(GuiceServerProbe.class); - private MailboxManager mailboxManager; - private DomainList domainList; - private UsersRepository usersRepository; + private final MailboxManager mailboxManager; + private final DomainList domainList; + private final UsersRepository usersRepository; @Inject private GuiceServerProbe(MailboxManager mailboxManager, DomainList domainList, UsersRepository usersRepository) { Modified: james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/InMemoryMailRepositoryStore.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/InMemoryMailRepositoryStore.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/InMemoryMailRepositoryStore.java (original) +++ james/project/trunk/server/container/cassandra-guice/src/main/java/org/apache/james/utils/InMemoryMailRepositoryStore.java Tue Jan 26 10:22:12 2016 @@ -45,10 +45,10 @@ public class InMemoryMailRepositoryStore private static final Logger LOGGER = LoggerFactory.getLogger(InMemoryMailRepositoryStore.class); - private Set<MailRepositoryProvider> mailRepositories; - private ConcurrentMap<String, MailRepository> destinationToRepositoryAssociations; - private Map<String, MailRepositoryProvider> protocolToRepositoryProvider; - private Map<String, HierarchicalConfiguration> perProtocolMailRepositoryDefaultConfiguration; + private final Set<MailRepositoryProvider> mailRepositories; + private final ConcurrentMap<String, MailRepository> destinationToRepositoryAssociations; + private final Map<String, MailRepositoryProvider> protocolToRepositoryProvider; + private final Map<String, HierarchicalConfiguration> perProtocolMailRepositoryDefaultConfiguration; private HierarchicalConfiguration configuration; @Inject Modified: james/project/trunk/server/container/cassandra-guice/src/test/java/org/apache/james/modules/TestFilesystemModule.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/cassandra-guice/src/test/java/org/apache/james/modules/TestFilesystemModule.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/cassandra-guice/src/test/java/org/apache/james/modules/TestFilesystemModule.java (original) +++ james/project/trunk/server/container/cassandra-guice/src/test/java/org/apache/james/modules/TestFilesystemModule.java Tue Jan 26 10:22:12 2016 @@ -34,7 +34,7 @@ import com.google.inject.name.Names; public class TestFilesystemModule extends AbstractModule { - private Supplier<File> workingDirectory; + private final Supplier<File> workingDirectory; private static File createTempDir(TemporaryFolder temporaryFolder) { try { Modified: james/project/trunk/server/container/core/src/main/java/org/apache/james/core/MimeMessageInputStream.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/core/src/main/java/org/apache/james/core/MimeMessageInputStream.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/core/src/main/java/org/apache/james/core/MimeMessageInputStream.java (original) +++ james/project/trunk/server/container/core/src/main/java/org/apache/james/core/MimeMessageInputStream.java Tue Jan 26 10:22:12 2016 @@ -31,7 +31,7 @@ import javax.mail.internet.MimeMessage; * Provide an {@link InputStream} over an {@link MimeMessage} */ public class MimeMessageInputStream extends InputStream { - private InputStream in; + private final InputStream in; /** * Provide an {@link InputStream} over a {@link MimeMessage}. Modified: james/project/trunk/server/container/core/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/core/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/core/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java (original) +++ james/project/trunk/server/container/core/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java Tue Jan 26 10:22:12 2016 @@ -52,7 +52,7 @@ public class MimeMessageInputStreamSourc /** * The full path of the temporary file */ - private String sourceId; + private final String sourceId; /** * 100kb threshold for the stream. Modified: james/project/trunk/server/container/core/src/main/java/org/apache/james/core/filesystem/UrlResource.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/core/src/main/java/org/apache/james/core/filesystem/UrlResource.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/core/src/main/java/org/apache/james/core/filesystem/UrlResource.java (original) +++ james/project/trunk/server/container/core/src/main/java/org/apache/james/core/filesystem/UrlResource.java Tue Jan 26 10:22:12 2016 @@ -27,7 +27,7 @@ import java.net.URLConnection; public class UrlResource implements Resource { public static final String URL_PROTOCOL_FILE = "file"; - private URL url; + private final URL url; public UrlResource(URL url) { this.url = url; Modified: james/project/trunk/server/container/jetty/src/main/java/org/apache/james/http/jetty/Configuration.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/jetty/src/main/java/org/apache/james/http/jetty/Configuration.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/jetty/src/main/java/org/apache/james/http/jetty/Configuration.java (original) +++ james/project/trunk/server/container/jetty/src/main/java/org/apache/james/http/jetty/Configuration.java Tue Jan 26 10:22:12 2016 @@ -42,12 +42,12 @@ public class Configuration { private static final Range<Integer> VALID_PORT_RANGE = Range.closed(1, 65535); - private ImmutableMap.Builder<String, Object> mappings; - private ImmutableMap.Builder<String, Object> filters; + private final ImmutableMap.Builder<String, Object> mappings; + private final ImmutableMap.Builder<String, Object> filters; private Optional<Integer> port; public class ServletBinder { - private String mappingUrl; + private final String mappingUrl; private ServletBinder(String mappingUrl) { this.mappingUrl = mappingUrl; @@ -67,7 +67,7 @@ public class Configuration { } public class FilterBinder { - private String filterUrl; + private final String filterUrl; private FilterBinder(String filterUrl) { this.filterUrl = filterUrl; Modified: james/project/trunk/server/container/jetty/src/main/java/org/apache/james/http/jetty/JettyHttpServer.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/jetty/src/main/java/org/apache/james/http/jetty/JettyHttpServer.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/jetty/src/main/java/org/apache/james/http/jetty/JettyHttpServer.java (original) +++ james/project/trunk/server/container/jetty/src/main/java/org/apache/james/http/jetty/JettyHttpServer.java Tue Jan 26 10:22:12 2016 @@ -42,7 +42,7 @@ public class JettyHttpServer implements return new JettyHttpServer(configuration); } - private Server server; + private final Server server; private ServerConnector serverConnector; private final Configuration configuration; Modified: james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/resource/DefaultJamesResourceLoader.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/resource/DefaultJamesResourceLoader.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/resource/DefaultJamesResourceLoader.java (original) +++ james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/resource/DefaultJamesResourceLoader.java Tue Jan 26 10:22:12 2016 @@ -34,7 +34,7 @@ import org.springframework.core.io.Resou */ public class DefaultJamesResourceLoader extends DefaultResourceLoader implements JamesResourceLoader { - private JamesDirectoriesProvider jamesDirectoriesProvider; + private final JamesDirectoriesProvider jamesDirectoriesProvider; public DefaultJamesResourceLoader(JamesDirectoriesProvider jamesDirectoriesProvider) { this.jamesDirectoriesProvider = jamesDirectoriesProvider; Modified: james/project/trunk/server/container/spring/src/test/java/org/apache/james/container/spring/filesystem/FileSystemImplTest.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/spring/src/test/java/org/apache/james/container/spring/filesystem/FileSystemImplTest.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/spring/src/test/java/org/apache/james/container/spring/filesystem/FileSystemImplTest.java (original) +++ james/project/trunk/server/container/spring/src/test/java/org/apache/james/container/spring/filesystem/FileSystemImplTest.java Tue Jan 26 10:22:12 2016 @@ -35,7 +35,7 @@ public class FileSystemImplTest extends } private class TestApplicationContextProvider extends JamesServerApplicationContext { - private String configurationRootDirectory; + private final String configurationRootDirectory; public TestApplicationContextProvider(String configurationRootDirectory, String[] configs) { super(configs); Modified: james/project/trunk/server/container/util/src/main/java/org/apache/james/util/concurrent/NamedThreadFactory.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/util/src/main/java/org/apache/james/util/concurrent/NamedThreadFactory.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/container/util/src/main/java/org/apache/james/util/concurrent/NamedThreadFactory.java (original) +++ james/project/trunk/server/container/util/src/main/java/org/apache/james/util/concurrent/NamedThreadFactory.java Tue Jan 26 10:22:12 2016 @@ -28,7 +28,7 @@ public class NamedThreadFactory implemen public final String name; private final AtomicLong count = new AtomicLong(); - private int priority; + private final int priority; public NamedThreadFactory(final String name, final int priority) { if (priority > Thread.MAX_PRIORITY || priority < Thread.MIN_PRIORITY) { Modified: james/project/trunk/server/data/data-cassandra/src/test/java/org/apache/james/rrt/cassandra/CassandraStepdefs.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/data/data-cassandra/src/test/java/org/apache/james/rrt/cassandra/CassandraStepdefs.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/data/data-cassandra/src/test/java/org/apache/james/rrt/cassandra/CassandraStepdefs.java (original) +++ james/project/trunk/server/data/data-cassandra/src/test/java/org/apache/james/rrt/cassandra/CassandraStepdefs.java Tue Jan 26 10:22:12 2016 @@ -31,7 +31,7 @@ public class CassandraStepdefs { private CassandraCluster cassandra; - private RewriteTablesStepdefs mainStepdefs; + private final RewriteTablesStepdefs mainStepdefs; public CassandraStepdefs(RewriteTablesStepdefs mainStepdefs) { this.mainStepdefs = mainStepdefs; Modified: james/project/trunk/server/data/data-file/src/test/java/org/apache/james/rrt/file/XMLStepdefs.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/data/data-file/src/test/java/org/apache/james/rrt/file/XMLStepdefs.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/data/data-file/src/test/java/org/apache/james/rrt/file/XMLStepdefs.java (original) +++ james/project/trunk/server/data/data-file/src/test/java/org/apache/james/rrt/file/XMLStepdefs.java Tue Jan 26 10:22:12 2016 @@ -26,7 +26,7 @@ import cucumber.api.java.Before; public class XMLStepdefs { - private RewriteTablesStepdefs mainStepdefs; + private final RewriteTablesStepdefs mainStepdefs; public XMLStepdefs(RewriteTablesStepdefs mainStepdefs) { this.mainStepdefs = mainStepdefs; Modified: james/project/trunk/server/data/data-jdbc/src/test/java/org/apache/james/rrt/jdbc/JDBCStepdefs.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/data/data-jdbc/src/test/java/org/apache/james/rrt/jdbc/JDBCStepdefs.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/data/data-jdbc/src/test/java/org/apache/james/rrt/jdbc/JDBCStepdefs.java (original) +++ james/project/trunk/server/data/data-jdbc/src/test/java/org/apache/james/rrt/jdbc/JDBCStepdefs.java Tue Jan 26 10:22:12 2016 @@ -32,7 +32,7 @@ import cucumber.api.java.Before; public class JDBCStepdefs { - private RewriteTablesStepdefs mainStepdefs; + private final RewriteTablesStepdefs mainStepdefs; public JDBCStepdefs(RewriteTablesStepdefs mainStepdefs) { this.mainStepdefs = mainStepdefs; Modified: james/project/trunk/server/data/data-jpa/src/test/java/org/apache/james/rrt/jpa/JPAStepdefs.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/data/data-jpa/src/test/java/org/apache/james/rrt/jpa/JPAStepdefs.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/data/data-jpa/src/test/java/org/apache/james/rrt/jpa/JPAStepdefs.java (original) +++ james/project/trunk/server/data/data-jpa/src/test/java/org/apache/james/rrt/jpa/JPAStepdefs.java Tue Jan 26 10:22:12 2016 @@ -33,7 +33,7 @@ import cucumber.api.java.Before; public class JPAStepdefs { - private RewriteTablesStepdefs mainStepdefs; + private final RewriteTablesStepdefs mainStepdefs; public JPAStepdefs(RewriteTablesStepdefs mainStepdefs) { this.mainStepdefs = mainStepdefs; Modified: james/project/trunk/server/data/data-library/src/main/java/org/apache/james/repository/file/ClassLoaderObjectInputStream.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/data/data-library/src/main/java/org/apache/james/repository/file/ClassLoaderObjectInputStream.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/data/data-library/src/main/java/org/apache/james/repository/file/ClassLoaderObjectInputStream.java (original) +++ james/project/trunk/server/data/data-library/src/main/java/org/apache/james/repository/file/ClassLoaderObjectInputStream.java Tue Jan 26 10:22:12 2016 @@ -29,7 +29,7 @@ import java.io.ObjectStreamClass; * Avalon components that are juggling many classloaders. */ public class ClassLoaderObjectInputStream extends ObjectInputStream { - private ClassLoader m_classLoader; + private final ClassLoader m_classLoader; public ClassLoaderObjectInputStream(final ClassLoader classLoader, final InputStream inputStream) throws IOException { super(inputStream); Modified: james/project/trunk/server/dns-service/dnsservice-dnsjava/src/test/java/org/apache/james/dnsservice/dnsjava/DNSJavaServiceTest.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/dns-service/dnsservice-dnsjava/src/test/java/org/apache/james/dnsservice/dnsjava/DNSJavaServiceTest.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/dns-service/dnsservice-dnsjava/src/test/java/org/apache/james/dnsservice/dnsjava/DNSJavaServiceTest.java (original) +++ james/project/trunk/server/dns-service/dnsservice-dnsjava/src/test/java/org/apache/james/dnsservice/dnsjava/DNSJavaServiceTest.java Tue Jan 26 10:22:12 2016 @@ -48,7 +48,7 @@ import java.util.Collection; public class DNSJavaServiceTest { private TestableDNSServer dnsServer; - private static byte[] DNS_SERVER_CONFIG = ("<dnsserver>" + + private static final byte[] DNS_SERVER_CONFIG = ("<dnsserver>" + "<autodiscover>true</autodiscover>" + "<authoritative>false</authoritative>" + "</dnsserver>").getBytes(); Modified: james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/jmx/MailProcessorManagement.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/jmx/MailProcessorManagement.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/jmx/MailProcessorManagement.java (original) +++ james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/jmx/MailProcessorManagement.java Tue Jan 26 10:22:12 2016 @@ -32,7 +32,7 @@ import org.apache.james.mailetcontainer. * {@link org.apache.james.mailetcontainer.impl.camel.CamelProcessor} implementations */ public class MailProcessorManagement extends StandardMBean implements MailProcessorManagementMBean { - private String processorName; + private final String processorName; private final AtomicLong errorCount = new AtomicLong(0); private final AtomicLong successCount = new AtomicLong(0); private final AtomicLong fastestProcessing = new AtomicLong(-1); Modified: james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/jmx/MatcherManagement.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/jmx/MatcherManagement.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/jmx/MatcherManagement.java (original) +++ james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/jmx/MatcherManagement.java Tue Jan 26 10:22:12 2016 @@ -27,7 +27,7 @@ import org.apache.james.mailetcontainer. import org.apache.mailet.MatcherConfig; public final class MatcherManagement extends StandardMBean implements MatcherManagementMBean { - private MatcherConfig matcherConfig; + private final MatcherConfig matcherConfig; private final AtomicLong errorCount = new AtomicLong(0); private final AtomicLong successCount = new AtomicLong(0); private final AtomicLong fastestProcessing = new AtomicLong(-1); Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/BypassAuthOnRequestMethod.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/BypassAuthOnRequestMethod.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/BypassAuthOnRequestMethod.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/BypassAuthOnRequestMethod.java Tue Jan 26 10:22:12 2016 @@ -42,7 +42,7 @@ public class BypassAuthOnRequestMethod i } public static class Builder { - private ImmutableList.Builder<Predicate<HttpServletRequest>> reasons = new ImmutableList.Builder<>(); + private final ImmutableList.Builder<Predicate<HttpServletRequest>> reasons = new ImmutableList.Builder<>(); private final AuthenticationFilter authenticationFilter; private Builder(AuthenticationFilter authenticationFilter) { Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/json/MultipleClassesDeserializer.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/json/MultipleClassesDeserializer.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/json/MultipleClassesDeserializer.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/json/MultipleClassesDeserializer.java Tue Jan 26 10:22:12 2016 @@ -34,7 +34,7 @@ import com.google.common.base.Throwables public class MultipleClassesDeserializer extends StdDeserializer<Object> { - private Map<String, Class<?>> registry = new HashMap<String, Class<?>>(); + private final Map<String, Class<?>> registry = new HashMap<String, Class<?>>(); MultipleClassesDeserializer() { super(Object.class); Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/json/MultipleObjectMapperBuilder.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/json/MultipleObjectMapperBuilder.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/json/MultipleObjectMapperBuilder.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/json/MultipleObjectMapperBuilder.java Tue Jan 26 10:22:12 2016 @@ -23,7 +23,7 @@ import com.fasterxml.jackson.databind.mo public class MultipleObjectMapperBuilder { - private MultipleClassesDeserializer multipleClassesDeserializer = new MultipleClassesDeserializer(); + private final MultipleClassesDeserializer multipleClassesDeserializer = new MultipleClassesDeserializer(); public MultipleObjectMapperBuilder registerClass(String uniqueJsonPath, Class<?> clazz) { multipleClassesDeserializer.registerClass(uniqueJsonPath, clazz); Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/GetMessagesMethod.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/GetMessagesMethod.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/GetMessagesMethod.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/GetMessagesMethod.java Tue Jan 26 10:22:12 2016 @@ -147,7 +147,7 @@ public class GetMessagesMethod<Id extend } private static class IncludeMessagePropertyPropertyFilter extends SimpleBeanPropertyFilter { - private Set<MessageProperty> propertiesToInclude; + private final Set<MessageProperty> propertiesToInclude; public IncludeMessagePropertyPropertyFilter(Set<MessageProperty> propertiesToInclude) { this.propertiesToInclude = propertiesToInclude; Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java Tue Jan 26 10:22:12 2016 @@ -111,8 +111,8 @@ public class JmapResponse { private final Method.Response.Name method; private final ClientId clientId; private final Method.Response response; - private Optional<? extends Set<? extends Property>> properties; - private Optional<SimpleFilterProvider> filterProvider; + private final Optional<? extends Set<? extends Property>> properties; + private final Optional<SimpleFilterProvider> filterProvider; private JmapResponse(Method.Response.Name method, ClientId clientId, Method.Response response, Optional<? extends Set<? extends Property>> properties, Optional<SimpleFilterProvider> filterProvider) { this.method = method; Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/ContinuationTokenResponse.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/ContinuationTokenResponse.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/ContinuationTokenResponse.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/ContinuationTokenResponse.java Tue Jan 26 10:22:12 2016 @@ -30,7 +30,7 @@ public class ContinuationTokenResponse { EXTERNAL("external"), PROMPT("prompt"); - private String value; + private final String value; AuthenticationMethod(String value) { this.value = value; Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/FilterCondition.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/FilterCondition.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/FilterCondition.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/FilterCondition.java Tue Jan 26 10:22:12 2016 @@ -40,8 +40,8 @@ public class FilterCondition implements @JsonPOJOBuilder(withPrefix = "") public static class Builder { - private ImmutableList.Builder<String> inMailboxes; - private ImmutableList.Builder<String> notInMailboxes; + private final ImmutableList.Builder<String> inMailboxes; + private final ImmutableList.Builder<String> notInMailboxes; private Date before; private Date after; private Integer minSize; @@ -58,7 +58,7 @@ public class FilterCondition implements private String bcc; private String subject; private String body; - private ImmutableList.Builder<String> header; + private final ImmutableList.Builder<String> header; private Builder() { inMailboxes = ImmutableList.builder(); Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/FilterOperator.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/FilterOperator.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/FilterOperator.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/FilterOperator.java Tue Jan 26 10:22:12 2016 @@ -38,7 +38,7 @@ public class FilterOperator implements F public static class Builder { private Operator operator; - private ImmutableList.Builder<Filter> conditionsBuilder; + private final ImmutableList.Builder<Filter> conditionsBuilder; private Builder() { conditionsBuilder = ImmutableList.builder(); Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMailboxesRequest.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMailboxesRequest.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMailboxesRequest.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMailboxesRequest.java Tue Jan 26 10:22:12 2016 @@ -40,8 +40,8 @@ public class GetMailboxesRequest impleme public static class Builder { private String accountId; - private ImmutableList.Builder<String> ids; private Optional<ImmutableSet<MailboxProperty>> properties; + private final ImmutableList.Builder<String> ids; private Builder() { ids = ImmutableList.builder(); Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMailboxesResponse.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMailboxesResponse.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMailboxesResponse.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMailboxesResponse.java Tue Jan 26 10:22:12 2016 @@ -37,8 +37,8 @@ public class GetMailboxesResponse implem private String accountId; private String state; - private ImmutableList.Builder<Mailbox> mailboxes; - private ImmutableList.Builder<String> notFoundBuilder; + private final ImmutableList.Builder<Mailbox> mailboxes; + private final ImmutableList.Builder<String> notFoundBuilder; private Builder() { mailboxes = ImmutableList.builder(); Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessageListRequest.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessageListRequest.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessageListRequest.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessageListRequest.java Tue Jan 26 10:22:12 2016 @@ -43,7 +43,7 @@ public class GetMessageListRequest imple private String accountId; private Filter filter; - private ImmutableList.Builder<String> sort; + private final ImmutableList.Builder<String> sort; private Boolean collapseThreads; private int position; private String anchor; @@ -51,7 +51,7 @@ public class GetMessageListRequest imple private Integer limit; private Boolean fetchThreads; private Boolean fetchMessages; - private ImmutableList.Builder<String> fetchMessageProperties; + private final ImmutableList.Builder<String> fetchMessageProperties; private Boolean fetchSearchSnippets; private Builder() { Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessageListResponse.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessageListResponse.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessageListResponse.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessageListResponse.java Tue Jan 26 10:22:12 2016 @@ -37,14 +37,14 @@ public class GetMessageListResponse impl private String accountId; private Filter filter; - private ImmutableList.Builder<String> sort; + private final ImmutableList.Builder<String> sort; private boolean collapseThreads; private String state; private boolean canCalculateUpdates; private int position; private int total; - private ImmutableList.Builder<String> threadIds; - private ImmutableList.Builder<String> messageIds; + private final ImmutableList.Builder<String> threadIds; + private final ImmutableList.Builder<String> messageIds; private Builder() { sort = ImmutableList.builder(); Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessagesRequest.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessagesRequest.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessagesRequest.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/GetMessagesRequest.java Tue Jan 26 10:22:12 2016 @@ -39,7 +39,7 @@ public class GetMessagesRequest implemen public static class Builder { private Optional<String> accountId; - private ImmutableList.Builder<MessageId> ids; + private final ImmutableList.Builder<MessageId> ids; private Optional<ImmutableSet<MessageProperty>> properties; private Builder() { Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/Message.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/Message.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/Message.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/Message.java Tue Jan 26 10:22:12 2016 @@ -168,18 +168,18 @@ public class Message { private boolean hasAttachment; private ImmutableMap<String, String> headers; private Emailer from; - private ImmutableList.Builder<Emailer> to; - private ImmutableList.Builder<Emailer> cc; - private ImmutableList.Builder<Emailer> bcc; - private ImmutableList.Builder<Emailer> replyTo; + private final ImmutableList.Builder<Emailer> to; + private final ImmutableList.Builder<Emailer> cc; + private final ImmutableList.Builder<Emailer> bcc; + private final ImmutableList.Builder<Emailer> replyTo; private String subject; private ZonedDateTime date; private Long size; private String preview; private String textBody; private String htmlBody; - private ImmutableList.Builder<Attachment> attachments; - private ImmutableMap.Builder<String, SubMessage> attachedMessages; + private final ImmutableList.Builder<Attachment> attachments; + private final ImmutableMap.Builder<String, SubMessage> attachedMessages; private Builder() { to = ImmutableList.builder(); Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/MessageProperty.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/MessageProperty.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/MessageProperty.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/MessageProperty.java Tue Jan 26 10:22:12 2016 @@ -53,9 +53,9 @@ public class MessageProperty implements public static MessageProperty attachedMessages = valueOf("attachedMessages"); public static MessageProperty body = valueOf("body"); - private static String HEADER_PROPERTY_PREFIX = "headers."; + private static final String HEADER_PROPERTY_PREFIX = "headers."; - private String property; + private final String property; private MessageProperty(String property) { this.property = property.toLowerCase(Locale.US); Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/SubMessage.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/SubMessage.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/SubMessage.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/SubMessage.java Tue Jan 26 10:22:12 2016 @@ -43,16 +43,16 @@ public class SubMessage { public static class Builder { private ImmutableMap<String, String> headers; private Emailer from; - private ImmutableList.Builder<Emailer> to; - private ImmutableList.Builder<Emailer> cc; - private ImmutableList.Builder<Emailer> bcc; - private ImmutableList.Builder<Emailer> replyTo; + private final ImmutableList.Builder<Emailer> to; + private final ImmutableList.Builder<Emailer> cc; + private final ImmutableList.Builder<Emailer> bcc; + private final ImmutableList.Builder<Emailer> replyTo; private String subject; private ZonedDateTime date; private String textBody; private String htmlBody; - private ImmutableList.Builder<Attachment> attachments; - private ImmutableMap.Builder<String, SubMessage> attachedMessages; + private final ImmutableList.Builder<Attachment> attachments; + private final ImmutableMap.Builder<String, SubMessage> attachedMessages; private Builder() { to = ImmutableList.builder(); Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/mailbox/Role.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/mailbox/Role.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/mailbox/Role.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/mailbox/Role.java Tue Jan 26 10:22:12 2016 @@ -32,7 +32,7 @@ public enum Role { SPAM("spam"), TEMPLATES("templates"); - private String name; + private final String name; Role(String name) { this.name = name; Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/message/HeaderCollection.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/message/HeaderCollection.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/message/HeaderCollection.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/message/HeaderCollection.java Tue Jan 26 10:22:12 2016 @@ -195,7 +195,7 @@ public class HeaderCollection { private final ImmutableSet<EMailer> replyToAddressSet; private final ImmutableSet<String> subjectSet; private final ImmutableMultimap<String, String> headers; - private Optional<ZonedDateTime> sentDate; + private final Optional<ZonedDateTime> sentDate; private HeaderCollection(ImmutableSet<EMailer> toAddressSet, ImmutableSet<EMailer> fromAddressSet, ImmutableSet<EMailer> ccAddressSet, ImmutableSet<EMailer> bccAddressSet, ImmutableSet<EMailer> replyToAddressSet, ImmutableSet<String> subjectSet, Modified: james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/message/MimePart.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/message/MimePart.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/message/MimePart.java (original) +++ james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/model/message/MimePart.java Tue Jan 26 10:22:12 2016 @@ -42,9 +42,9 @@ public class MimePart { public static class Builder implements MimePartContainerBuilder { - private HeaderCollection.Builder headerCollectionBuilder; + private final HeaderCollection.Builder headerCollectionBuilder; private Optional<InputStream> bodyContent; - private List<MimePart> children; + private final List<MimePart> children; private Optional<String> mediaType; private Optional<String> subType; private Optional<String> fileName; Modified: james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/AbstractCommandHandlerStats.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/AbstractCommandHandlerStats.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/AbstractCommandHandlerStats.java (original) +++ james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/AbstractCommandHandlerStats.java Tue Jan 26 10:22:12 2016 @@ -41,10 +41,10 @@ public abstract class AbstractCommandHan private final AtomicLong all = new AtomicLong(0); private final AtomicLong disconnect = new AtomicLong(); - private String name; - private String handlerName; - private MBeanServer mbeanserver; - private String[] commands; + private final String name; + private final String handlerName; + private final MBeanServer mbeanserver; + private final String[] commands; public AbstractCommandHandlerStats(Class<?> jmxClass, String jmxName, String handlerName, String[] commands) throws NotCompliantMBeanException, MalformedObjectNameException, NullPointerException, InstanceAlreadyExistsException, MBeanRegistrationException { super(jmxClass); Modified: james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/ConnectHandlerStats.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/ConnectHandlerStats.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/ConnectHandlerStats.java (original) +++ james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/ConnectHandlerStats.java Tue Jan 26 10:22:12 2016 @@ -34,9 +34,9 @@ import org.apache.james.protocols.api.Re public class ConnectHandlerStats extends StandardMBean implements HandlerStatsMBean, Disposable { - private String name; - private String handlerName; - private MBeanServer mbeanserver; + private final String name; + private final String handlerName; + private final MBeanServer mbeanserver; private final AtomicLong all = new AtomicLong(0); private final AtomicLong disconnect = new AtomicLong(0); Modified: james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/LineHandlerStats.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/LineHandlerStats.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/LineHandlerStats.java (original) +++ james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/jmx/LineHandlerStats.java Tue Jan 26 10:22:12 2016 @@ -37,9 +37,9 @@ import org.apache.james.protocols.api.Re */ public class LineHandlerStats extends StandardMBean implements HandlerStatsMBean, Disposable { - private String name; - private String handlerName; - private MBeanServer mbeanserver; + private final String name; + private final String handlerName; + private final MBeanServer mbeanserver; private final AtomicLong all = new AtomicLong(0); private final AtomicLong disconnect = new AtomicLong(0); Modified: james/project/trunk/server/protocols/protocols-managesieve/src/main/java/org/apache/james/managesieveserver/netty/ManageSieveServer.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-managesieve/src/main/java/org/apache/james/managesieveserver/netty/ManageSieveServer.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/protocols-managesieve/src/main/java/org/apache/james/managesieveserver/netty/ManageSieveServer.java (original) +++ james/project/trunk/server/protocols/protocols-managesieve/src/main/java/org/apache/james/managesieveserver/netty/ManageSieveServer.java Tue Jan 26 10:22:12 2016 @@ -58,8 +58,8 @@ public class ManageSieveServer extends A final static String CHUNK_WRITE_HANDLER = "chunkWriteHandler"; final static String EXECUTION_HANDLER = "executionHandler"; - private int maxLineLength; - private ManageSieveProcessor manageSieveProcessor; + private final int maxLineLength; + private final ManageSieveProcessor manageSieveProcessor; public ManageSieveServer(int maxLineLength, ManageSieveProcessor manageSieveProcessor) { this.maxLineLength = maxLineLength; Modified: james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/jmx/HookStats.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/jmx/HookStats.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/jmx/HookStats.java (original) +++ james/project/trunk/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/jmx/HookStats.java Tue Jan 26 10:22:12 2016 @@ -43,9 +43,9 @@ public class HookStats extends StandardM private final AtomicLong denysoft = new AtomicLong(0); private final AtomicLong all = new AtomicLong(0); - private String name; - private MBeanServer mbeanserver; - private String hookname; + private final String name; + private final MBeanServer mbeanserver; + private final String hookname; public HookStats(String jmxName, String hookname) throws InstanceAlreadyExistsException, MBeanRegistrationException, NotCompliantMBeanException, MalformedObjectNameException, NullPointerException { super(HookStatsMBean.class); Modified: james/project/trunk/server/queue/queue-activemq/src/main/java/org/apache/james/queue/activemq/MimeMessageBlobMessageSource.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/queue/queue-activemq/src/main/java/org/apache/james/queue/activemq/MimeMessageBlobMessageSource.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/queue/queue-activemq/src/main/java/org/apache/james/queue/activemq/MimeMessageBlobMessageSource.java (original) +++ james/project/trunk/server/queue/queue-activemq/src/main/java/org/apache/james/queue/activemq/MimeMessageBlobMessageSource.java Tue Jan 26 10:22:12 2016 @@ -31,7 +31,7 @@ import org.apache.james.core.MimeMessage */ public class MimeMessageBlobMessageSource extends MimeMessageSource implements ActiveMQSupport { - private String sourceId; + private final String sourceId; private final BlobMessage message; public MimeMessageBlobMessageSource(BlobMessage message) throws JMSException { Modified: james/project/trunk/server/queue/queue-file/src/main/java/org/apache/james/queue/file/FileMailQueue.java URL: http://svn.apache.org/viewvc/james/project/trunk/server/queue/queue-file/src/main/java/org/apache/james/queue/file/FileMailQueue.java?rev=1726759&r1=1726758&r2=1726759&view=diff ============================================================================== --- james/project/trunk/server/queue/queue-file/src/main/java/org/apache/james/queue/file/FileMailQueue.java (original) +++ james/project/trunk/server/queue/queue-file/src/main/java/org/apache/james/queue/file/FileMailQueue.java Tue Jan 26 10:22:12 2016 @@ -42,7 +42,7 @@ import javax.mail.MessagingException; import javax.mail.util.SharedFileInputStream; import org.apache.commons.io.FileUtils; -import org.apache.commons.io.IOUtils; +import org.apache.commons.io.IOUtils; import org.apache.james.core.MimeMessageCopyOnWriteProxy; import org.apache.james.core.MimeMessageSource; import org.apache.james.lifecycle.api.Disposable; @@ -323,7 +323,7 @@ public class FileMailQueue implements Ma private final class FileMimeMessageSource extends MimeMessageSource implements Disposable { private File file; - private SharedFileInputStream in; + private final SharedFileInputStream in; public FileMimeMessageSource(File file) throws IOException { this.file = file; @@ -352,7 +352,7 @@ public class FileMailQueue implements Ma @Override public void dispose() { - IOUtils.closeQuietly(in); + IOUtils.closeQuietly(in); file = null; } --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
