[
https://issues.apache.org/jira/browse/JAMES-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187447#comment-16187447
]
ASF GitHub Bot commented on JAMES-992:
--------------------------------------
Github user chibenwa commented on a diff in the pull request:
https://github.com/apache/james-project/pull/73#discussion_r142033017
--- Diff:
mailet/standard/src/main/java/org/apache/james/transport/matchers/HasMimeType.java
---
@@ -0,0 +1,61 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information *
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the *
+ * "License"); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the *
+ * specific language governing permissions and limitations *
+ * under the License. *
+ ****************************************************************/
+
+
+package org.apache.james.transport.matchers;
+
+import com.google.common.collect.ImmutableSet;
+import org.apache.james.core.MailAddress;
+import org.apache.mailet.Mail;
+import org.apache.mailet.base.GenericMatcher;
+
+import javax.activation.MimeType;
+import javax.activation.MimeTypeParseException;
+import javax.mail.MessagingException;
+import javax.mail.internet.MimeMessage;
+
+import java.util.*;
+
+/**
+ * <p>This matcher checks if the content type matches.</p>
+ */
+public class HasMimeType extends GenericMatcher {
+
+ private Set<String> content_types;
+
+ public void init() throws javax.mail.MessagingException {
+ content_types =
ImmutableSet.copyOf(getCondition().split("\\s*,\\s*"));
+ }
+
+ public Collection<MailAddress> match(Mail mail) throws
javax.mail.MessagingException {
+ String mimeType;
+ try {
+ mimeType = getMimeTypeFromMessage(mail.getMessage());
+ } catch (MimeTypeParseException e) {
+ mimeType = null;
+ }
+ return (content_types.contains(mimeType)) ? mail.getRecipients() :
null;
--- End diff --
We should avoid returning null. An empty list is better :-)
> Limit max line length for protocol when using Netty
> ---------------------------------------------------
>
> Key: JAMES-992
> URL: https://issues.apache.org/jira/browse/JAMES-992
> Project: James Server
> Issue Type: Improvement
> Reporter: Norman Maurer
> Fix For: 3.0-M1
>
>
> We should limit the max characters per line so nobody can cause OOM when
> doing a DOS attach
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
