[
https://issues.apache.org/jira/browse/JAMES-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187692#comment-16187692
]
ASF GitHub Bot commented on JAMES-992:
--------------------------------------
Github user chibenwa commented on a diff in the pull request:
https://github.com/apache/james-project/pull/73#discussion_r142062789
--- Diff:
mailet/standard/src/test/java/org/apache/james/transport/matchers/HasMimeTypeTest.java
---
@@ -0,0 +1,93 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information *
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the *
+ * "License"); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the *
+ * specific language governing permissions and limitations *
+ * under the License. *
+ ****************************************************************/
+
+package org.apache.james.transport.matchers;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.Assert.assertEquals;
+
+import org.apache.james.core.MailAddress;
+import org.apache.mailet.base.test.FakeMail;
+import org.apache.mailet.base.test.FakeMatcherConfig;
+import org.apache.mailet.base.test.MimeMessageBuilder;
+import org.junit.Before;
+import org.junit.Test;
+
+import javax.mail.MessagingException;
+import javax.mail.internet.MimeMessage;
+import java.util.Collections;
+
+public class HasMimeTypeTest {
+
+ private static final String RECIPIENT = "[email protected]";
+ private static final String FROM = "[email protected]";
+ private static final String MIME_TYPES = "multipart/mixed";
+ private static final String NON_MATCHING_MIME_TYPES = "text/plain,
application/zip";
+
+ private HasMimeType matcher;
+ private FakeMail mail;
+
+ @Before
+ public void setUp() throws Exception {
+ matcher = new HasMimeType();
+ MimeMessage message = MimeMessageBuilder.mimeMessageBuilder()
+ .setMultipartWithBodyParts(
+ MimeMessageBuilder.bodyPartBuilder()
+ .data("simple text")
+ .disposition("text")
+ .build(),
+ MimeMessageBuilder.bodyPartBuilder()
+ .filename("text_file.txt")
+ .disposition("attachment")
+ .build(),
+ MimeMessageBuilder.bodyPartBuilder()
+ .type("application/zip")
+ .filename("zip_file.zip")
+ .disposition("attachment")
+ .build())
+ .setSubject("test")
+ .build();
+
+ mail = FakeMail.builder()
+ .mimeMessage(message)
+ .sender(new MailAddress(FROM))
+ .recipient(new MailAddress(RECIPIENT))
+ .build();
+ }
+
+ @Test
+ public void hasMimeType() throws MessagingException {
+ matcher.init(FakeMatcherConfig.builder()
+ .matcherName("HasMimeType")
+ .condition(MIME_TYPES)
+ .build());
+
+ assertThat(matcher.match(mail)).containsAll(mail.getRecipients());
+ }
+
+ @Test
+ public void doesNotHaveMimeType() throws MessagingException{
+ matcher.init(FakeMatcherConfig.builder()
+ .matcherName("HasMimeType")
+ .condition(NON_MATCHING_MIME_TYPES)
+ .build());
+
+ assertEquals(matcher.match(mail), Collections.emptyList());
--- End diff --
You can do this one also with assertJ :
```
assertThat(matcher.match(mail)).isEmpty();
```
Then you might simplify imports.
> Limit max line length for protocol when using Netty
> ---------------------------------------------------
>
> Key: JAMES-992
> URL: https://issues.apache.org/jira/browse/JAMES-992
> Project: James Server
> Issue Type: Improvement
> Reporter: Norman Maurer
> Fix For: 3.0-M1
>
>
> We should limit the max characters per line so nobody can cause OOM when
> doing a DOS attach
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
