[
https://issues.apache.org/jira/browse/JAMES-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456053#comment-16456053
]
ASF GitHub Bot commented on JAMES-2382:
---------------------------------------
Github user chibenwa commented on the issue:
https://github.com/apache/james-project/pull/110
Hi,
This pull request has just been merged.
Thank you again for your dedication toward the James project. If you need
help, want to
[contribute](https://issues.apache.org/jira/issues/?jql=project%20%3D%20JAMES%20AND%20resolution%20%3D%20Unresolved%20AND%20labels%20%3D%20newbie%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC)
[documentation](https://issues.apache.org/jira/issues/?jql=project%20%3D%20JAMES%20AND%20resolution%20%3D%20Unresolved%20AND%20labels%20%3D%20documentation%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC),
new
[features](https://issues.apache.org/jira/issues/?jql=project%20%3D%20JAMES%20AND%20resolution%20%3D%20Unresolved%20AND%20labels%20%3D%20feature%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC),
tests or
[bugfix](https://issues.apache.org/jira/issues/?jql=project%20%3D%20JAMES%20AND%20resolution%20%3D%20Unresolved%20AND%20labels%20%3D%20easyfix%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC),
please don't hesitate to reach us.
One very last thing: I don't have write access to this repository, hence I
can not close this issue. Wouldn't you mind doing it for me? It would avoid me
annoying the Apache INFRA team with such simple concerns.
Thanks again,
Cheers,
Benoit
> Inconsistent method name
> ------------------------
>
> Key: JAMES-2382
> URL: https://issues.apache.org/jira/browse/JAMES-2382
> Project: James Server
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
>
> The following method is named "hasAnnotatedProperty" that is a query of
> asking whether the propertyDescriptor has the AnnotatedProperty or not.
> Actually, the method returns an AnnotatedProperty found by the
> propertyDescriptor.
> Thus, the method name "findAnnotatedProperty" should be intuitive than
> "hasAnnotatedProperty".
> {code:java}
> private A hasAnnotatedProperty(PropertyDescriptor propertyDescriptor) {
> Method setter = propertyDescriptor.getWriteMethod();
> return setter != null ? AnnotationUtils.getAnnotation(setter,
> getAnnotation()) : null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
