[ 
https://issues.apache.org/jira/browse/JAMES-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456080#comment-16456080
 ] 

ASF GitHub Bot commented on JAMES-2382:
---------------------------------------

Github user chibenwa commented on the issue:

    https://github.com/apache/james-project/pull/110
  
    Thank you!


> Inconsistent method name
> ------------------------
>
>                 Key: JAMES-2382
>                 URL: https://issues.apache.org/jira/browse/JAMES-2382
>             Project: James Server
>          Issue Type: Improvement
>            Reporter: KuiLIU
>            Priority: Major
>
> The following method is named "hasAnnotatedProperty" that is a query of 
> asking whether the propertyDescriptor has the AnnotatedProperty or not.
> Actually, the method returns an AnnotatedProperty found by the 
> propertyDescriptor.
> Thus, the method name "findAnnotatedProperty" should be intuitive than 
> "hasAnnotatedProperty".
> {code:java}
>     private A hasAnnotatedProperty(PropertyDescriptor propertyDescriptor) {
>         Method setter = propertyDescriptor.getWriteMethod();
>         return setter != null ? AnnotationUtils.getAnnotation(setter, 
> getAnnotation()) : null;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to