This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 5e5c80f9171438f5af387c5be7511a68f678716f Author: Benoit Tellier <btell...@linagora.com> AuthorDate: Fri May 29 10:24:56 2020 +0700 [ADR] Enforce monotic ADR id increment --- src/adr/0026-removing-configured-additional-mailboxListeners.md | 2 +- src/adr/0027-eventBus-error-handling-upon-dispatch.md | 2 +- src/adr/0035-distributed-listeners-configuration.md | 4 ++-- src/adr/{0036-eventbus.md => 0037-eventbus.md} | 4 ++-- .../{0037-distributed-eventbus.md => 0038-distributed-eventbus.md} | 4 ++-- ...arbage-collector.md => 0039-distributed-blob-garbage-collector.md} | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/adr/0026-removing-configured-additional-mailboxListeners.md b/src/adr/0026-removing-configured-additional-mailboxListeners.md index f81c59b..5eefb81 100644 --- a/src/adr/0026-removing-configured-additional-mailboxListeners.md +++ b/src/adr/0026-removing-configured-additional-mailboxListeners.md @@ -19,7 +19,7 @@ The distributed James server then declares a queue upon start for each one of th binds to the main event exchange. More information about this component, and its distributed, RabbitMQ based implementation, can be found in -[ADR 0036](0036-eventbus.md). +[ADR 0036](0037-eventbus.md). If the user unconfigures the listener, the queue and the binding are still present but not consumed. This results in unbounded queue growth eventually causing RabbitMQ resource exhaustion and failure. diff --git a/src/adr/0027-eventBus-error-handling-upon-dispatch.md b/src/adr/0027-eventBus-error-handling-upon-dispatch.md index 053b713..bdb36ff 100644 --- a/src/adr/0027-eventBus-error-handling-upon-dispatch.md +++ b/src/adr/0027-eventBus-error-handling-upon-dispatch.md @@ -19,7 +19,7 @@ order to retry their processing via webAdmin APIs. However no such capabilities are supported upon dispatching the event on the eventbus. A failed dispatch will result in message loss. -More information about this component can be found in [ADR 0036](0036-eventbus.md). +More information about this component can be found in [ADR 0036](0037-eventbus.md). ## Decision diff --git a/src/adr/0035-distributed-listeners-configuration.md b/src/adr/0035-distributed-listeners-configuration.md index 78ada23..120e7ad 100644 --- a/src/adr/0035-distributed-listeners-configuration.md +++ b/src/adr/0035-distributed-listeners-configuration.md @@ -19,7 +19,7 @@ Mailbox listeners can be registered to be triggered every time an event is gener mailbox. They are being executed in a distributed fashion following the workqueue messaging pattern. The "group" is an attribute of the mailbox listener identifying to which work queue they belong. -More information about this component can be found in [ADR 0036](0036-eventbus.md). +More information about this component can be found in [ADR 0036](0037-eventbus.md). Currently, mailbox listeners are determined by the guice bindings of the server and additional mailbox listeners defined via configuration files. @@ -78,7 +78,7 @@ A WebAdmin endpoint will allow: A broadcast on the event bus will be attempted to propagate topology changes, by the mean of a common registrationKey to all nodes, a "TopologyChanged" event, and a mailbox listener starting the MailboxListeners on local node upon -topology changes. `registrationKey` concept is explained in [ADR 0036](0036-eventbus.md). +topology changes. `registrationKey` concept is explained in [ADR 0036](0037-eventbus.md). If a listener is added but is not in the classpath, an ERROR log is emitted. This can happen during a rolling upgrade, which defines a new guice binding for a new mailbox listener. Events will still be emitted (and consumed by other James diff --git a/src/adr/0036-eventbus.md b/src/adr/0037-eventbus.md similarity index 98% rename from src/adr/0036-eventbus.md rename to src/adr/0037-eventbus.md index e16f782..f52b9f8 100644 --- a/src/adr/0036-eventbus.md +++ b/src/adr/0037-eventbus.md @@ -1,4 +1,4 @@ -# 36. Event bus +# 37. Event bus Date: 2020-05-05 @@ -48,7 +48,7 @@ key it is registered to, in an at least once fashion. We need to provide an `In VM` implementation of the EventBus for single server deployments. -We also need to provide [a distributed event bus implementation](0037-distributed-eventbus.md). +We also need to provide [a distributed event bus implementation](0038-distributed-eventbus.md). ## Current usages diff --git a/src/adr/0037-distributed-eventbus.md b/src/adr/0038-distributed-eventbus.md similarity index 94% rename from src/adr/0037-distributed-eventbus.md rename to src/adr/0038-distributed-eventbus.md index eea132e..cb02ac6 100644 --- a/src/adr/0037-distributed-eventbus.md +++ b/src/adr/0038-distributed-eventbus.md @@ -1,4 +1,4 @@ -# 37. Distributed Event bus +# 38. Distributed Event bus Date: 2020-05-25 @@ -8,7 +8,7 @@ Accepted (lazy consensus) ## Context -Read [Event Bus ADR](0036-eventbus.md) for context. +Read [Event Bus ADR](0037-eventbus.md) for context. Given several James servers, we need them to share a common EventBus. diff --git a/src/adr/0029-distributed-blob-garbage-collector.md b/src/adr/0039-distributed-blob-garbage-collector.md similarity index 99% rename from src/adr/0029-distributed-blob-garbage-collector.md rename to src/adr/0039-distributed-blob-garbage-collector.md index 36b3bdc..d2bcca1 100644 --- a/src/adr/0029-distributed-blob-garbage-collector.md +++ b/src/adr/0039-distributed-blob-garbage-collector.md @@ -1,4 +1,4 @@ -# 29. Distributed blob garbage collector +# 39. Distributed blob garbage collector Date: 2020-02-18 --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org