This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit af1f391a08175090b1e22bab679b87d7b4abcaaa
Author: Benoit Tellier <btell...@linagora.com>
AuthorDate: Mon Jun 1 11:56:40 2020 +0700
JAMES-3182 JMAPResponse Error: Remove ambiguous untyped builder method
I assumed from method signature that the string parameter was a message
while it was used for type.
I removed this unused ambiguous method about to make me introduce a bug
---
.../main/java/org/apache/james/jmap/draft/methods/JmapResponse.java | 6 ------
1 file changed, 6 deletions(-)
diff --git
a/server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/methods/JmapResponse.java
b/server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/methods/JmapResponse.java
index 3174e95..8113098 100644
---
a/server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/methods/JmapResponse.java
+++
b/server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/methods/JmapResponse.java
@@ -81,12 +81,6 @@ public class JmapResponse {
this.responseName = ErrorResponse.ERROR_METHOD;
return this;
}
-
- public Builder error(String message) {
- this.response = ErrorResponse.builder().type(message).build();
- this.responseName = ErrorResponse.ERROR_METHOD;
- return this;
- }
public Builder error(ErrorResponse error) {
this.response = error;
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
