[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234726#comment-17234726
]
ASF GitHub Bot commented on JAMES-2124:
---------------------------------------
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526184190
##########
File path:
server/protocols/jmap-rfc-8621-integration-tests/distributed-jmap-rfc-8621-integration-tests/pom.xml
##########
@@ -17,19 +17,17 @@
specific language governing permissions and limitations
under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0";
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
Review comment:
it's not mandatory but because whitespace is considered non-significant
in the XML specification parsers don't keep position information in many cases
this is one of them. Since
- there were few pom affected by the whitespace removal
- this will prevent spurious modifications that humans will have to think
about
- the namespace declaration on the project tag are more or less noise to
humans
I added the few normalizations to the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
> ----------------
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
> Affects Versions: master
> Reporter: Benoit Tellier
> Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
