[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234818#comment-17234818
]
ASF GitHub Bot commented on JAMES-2124:
---------------------------------------
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526244131
##########
File path: mailbox/api/pom.xml
##########
@@ -45,10 +49,6 @@
<artifactId>james-server-task-memory</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>${james.groupId}</groupId>
- <artifactId>apache-mime4j-dom</artifactId>
Review comment:
I will make the change.
However I would like to point out
https://maven.apache.org/guides/mini/guide-naming-conventions.html
> groupId uniquely identifies your project across all projects. [...] That
is, if the current project is a multiple module project, it should append a new
identifier to the parent's groupId.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
> ----------------
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
> Affects Versions: master
> Reporter: Benoit Tellier
> Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
