[
https://issues.apache.org/jira/browse/JAMES-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248824#comment-17248824
]
ASF GitHub Bot commented on JAMES-3477:
---------------------------------------
chibenwa commented on pull request #280:
URL: https://github.com/apache/james-project/pull/280#issuecomment-744292453
> I know all the effort that has been invested in all this, but I would very
much like to see the benchmark that led to implement this copy on write scheme
instead of simply copying on every instantiation.
:+1: we need to know if it worth it
We need to see if this code complexity is worth it (I am not super fan of
the proposed solution here that partially resolves the problem)
> It feels like trying to preserver heap space at the cost of
synchronization this is optimization territory and should be backed by
measurements that are kept up to date for new releases.
We are trying to avoid disk writes that could happen from this copy from
what I understand.
> I wonder what the perf profile of the server would look like with a more
naive copy approach.
We need to design a test, where emails are actually split (matcher splitting
leads to several copies being hold)
We could do micro benchmark of 1000 processed emails of 100KB split 5 time
against both implems. What would you think ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> MimeMessageCopyOnWriteProxy is not thread safe
> ----------------------------------------------
>
> Key: JAMES-3477
> URL: https://issues.apache.org/jira/browse/JAMES-3477
> Project: James Server
> Issue Type: Wish
> Reporter: Benoit Tellier
> Priority: Major
>
> https://www.mail-archive.com/[email protected]/msg69221.html
> &
> https://github.com/jeantil/james-project/commit/c0354ea21c5b0a8f6d46e9919f7db0d97db9eb23
> proves there is a concurrency issue in MimeMessageCopyOnWriteProxy class that
> we need to investigate.
> It causes our test suite to be flacky.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
