[ 
https://issues.apache.org/jira/browse/JAMES-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248923#comment-17248923
 ] 

ASF GitHub Bot commented on JAMES-3477:
---------------------------------------

chibenwa commented on pull request #280:
URL: https://github.com/apache/james-project/pull/280#issuecomment-744378892


   Add a quick 'toy' micro-benchmark for evaluating mailetcon…
   32d1fca
   
   …tainer efficiency
   
   On top of master: 16.691 ms
   
   On top of the proposed changes: 17.126 ms
   
   With "always copy" behavior: 15.442 ms
   
   Implementation of "always copy" behavior:
   
   ```
        private MimeMessageCopyOnWriteProxy(MimeMessage original, boolean 
originalIsAReference) {
           super(Session.getDefaultInstance(System.getProperties(), null));
   
           try {
               refCount = new MessageReferenceTracker(new 
MimeMessageWrapper(original));
           } catch (MessagingException e) {
               throw new RuntimeException(e);
           }
       }
   ```
   
   Performance gains of copy-on-write proxy are not obvious...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> MimeMessageCopyOnWriteProxy is not thread safe
> ----------------------------------------------
>
>                 Key: JAMES-3477
>                 URL: https://issues.apache.org/jira/browse/JAMES-3477
>             Project: James Server
>          Issue Type: Wish
>            Reporter: Benoit Tellier
>            Priority: Major
>
> https://www.mail-archive.com/[email protected]/msg69221.html
> & 
> https://github.com/jeantil/james-project/commit/c0354ea21c5b0a8f6d46e9919f7db0d97db9eb23
> proves there is a concurrency issue in MimeMessageCopyOnWriteProxy class that 
> we need to investigate.
> It causes our test suite to be flacky.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to