On 3/31/2011 7:55 PM, David Holmes wrote:
Daniel D. Daugherty said the following on 04/01/11 11:27:
On 3/31/2011 7:10 PM, Dr Andrew John Hughes wrote:
If this looks ok, it needs a bug ID and then pushing to JPRT by some
friendly Oracle HotSpot developer :-).
Actually, I think we can use the following bug ID:
7010849 5/5 Extraneous javac source/target options when building
sa-jdi
if David H doesn't mind it being used for this push.
No objections from me. We can just update the description or eval to
clarify that we took the opportunity to upgrade to 1.6 support.
I made myself RE of 7010849 and updated the evaluation.
I'll look at the webrev in the morning when my brain is less fried
and I'll take care of the testing and pushing...
I just looked at the webrev and it all looks good to me. Had to think
a little about some of the varargs changes, but all seems ok. :)
Thumbs up from me also. The only change I'll make is to
update the copyright years in the touched files.
I'll get a repo setup, apply the patch and do some quick
sanity testing. If all goes well, then I should be able to
push this changeset today.
Dan
Cheers,
David
