Dan,
VerifyLocalVariableTableOnRetransformTest.sh
1.
if [ "${TESTJAVA}" = "" ]
Some shells doesn't handle it correctly.
It's more safe to do
if [ "x${TESTJAVA}" = "x" ]
(the same is for other conditions below)
2.
ll. 69
it's better to add quotes around 0 or
use -eq instead of =
besides that looks good for me.
-Dmitry
On 2012-08-15 20:58, Daniel D. Daugherty wrote:
> Greetings,
>
> I wrote a test for the following bug:
>
> 7064927 4/4 retransformClasses() does not pass in
> LocalVariableTable of a method
>
> a long time ago. 7064927 was fixed in the hotspot repo back in
> HSX-23-B09 by Thomas W. and Coleen, but the test was never pushed
> to the JDK repo. The java.lang.instrument (JLI) tests live in the
> JDK repo.
>
> I'm using the following bug:
>
> 7191322 4/4 add test for 7064927 to java.lang.instrument
>
> to get the test into the JDK8 T&L repo. Here is the webrev URL:
>
> http://cr.openjdk.java.net/~dcubed/7191322-webrev/0/
>
> Thanks, in advance, for any comments.
>
> Dan
>
> P.S.
> The new test has been executed and passes on all platforms
> supported by JPRT except for MacOS X. There is a temporary
> build issue on MacOS X at the moment.
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
