On 7/9/13 3:02 AM, Jaroslav Bachorik wrote:
Please, review the final version of the changes:
http://cr.openjdk.java.net/~jbachorik/8010285/webrev.07
The change looks reasonable. In the class spec for MXBean, suggest to
rename
interface ThisIsNotMXBean{}
to something more explicit
interface NonPublicInterfaceNotMXBean{}
You removed JMX.checkProxyInterface. I believe the checkPackageAccess method
on the given mbean
interface is called somewhere as part of the MBean validation - where is that
check being done?
Other than that, it's fine with me.
Mandy
It addresses all the concerns raised during the CCC process.
I will need at least one official OpenJDK reviewer for the integration.
Thanks,
-JB-
