Thomas, On Tuesday 15 October 2013 12.53.25 Thomas Schatzl wrote: > Hi all, > > can I have reviews for the following change? It updates the SA agent > that got out of date after the changes for JDK-7163191 where the > HeapRegionSeq class has been refactored. > > The changes mirror the changes in the C++ code of that revision, adding > a G1HeapRegionTable java class, and the associated modifications in the > HeapRegionSeq class. > > There have been no interface changes to the HeapRegionSeq class to avoid > breakage of any tools depending on it. > > Webrev: > http://cr.openjdk.java.net/~tschatzl/8025925/webrev/
Why did you change the copyright header format? "2011, 2013" is the format we should use, where 2011 is the first year and 2013 is the year when it was last modified. Otherwise I think the changes look good. Do you know if any part of the SA code base actually uses this class? /Mikael > > Testing: > Connecting an SA-agent with the change on a running java program; test > case in bug report > > (I added the serviceability-dev mailing list as additional recipients as > the change also concerns this part of the VM) > > Thanks, > Thomas
