On 17 feb 2014, at 02:30, David Holmes <david.hol...@oracle.com> wrote:
> On 11/02/2014 10:01 PM, Staffan Larsen wrote: >> >> On 11 feb 2014, at 12:14, Erik Joelsson <erik.joels...@oracle.com> wrote: >> >>> Looks good, but I can't help but wonder why the mapfile for libjfr is in >>> the open. >> >> Yes, that is unfortunate. It used to be in closed source in jdk7, but moved >> into open with the new build system. > > That should be fixed. Looks like we need a make/closed/lib/Serviceability.gmk > that contains the BUILD_LIBJFR definition. Yes, I’ve filed a bug about it. Thanks, /Staffan > > David > >> /Staffan >> >>> >>> /Erik >>> >>> On 2014-02-11 12:00, Staffan Larsen wrote: >>>> Resending (email to build-dev bounced since I used the wrong sender >>>> address). >>>> >>>> On 11 feb 2014, at 11:18, staf...@larsen.se wrote: >>>> >>>>> Please review this small fix for libjfr/mapfile-vers. >>>>> >>>>> Thanks, >>>>> /Staffan >>>>> >>>>> diff --git a/make/mapfiles/libjfr/mapfile-vers >>>>> b/make/mapfiles/libjfr/mapfile-vers >>>>> --- a/make/mapfiles/libjfr/mapfile-vers >>>>> +++ b/make/mapfiles/libjfr/mapfile-vers >>>>> @@ -34,6 +34,7 @@ >>>>> Java_oracle_jrockit_jfr_VMJFR_getPeriod; >>>>> Java_oracle_jrockit_jfr_VMJFR_descriptors; >>>>> Java_oracle_jrockit_jfr_VMJFR_redefineClass0; >>>>> + Java_oracle_jrockit_jfr_VMJFR_retransformClasses0; >>>>> JNI_OnLoad; >>>>> local: >>>>> *; >>> >>
