Looks good to me Frederic. JVM_Read is restartable, but that may not be an issue here.
-Chris. > On 28 Feb 2014, at 21:19, frederic parain <frederic.par...@oracle.com> wrote: > > Greetings, > > Please review this small changeset for CR JDK-8035952 > "Remove use of JVM_Open, JVM_Read and JVM_Close functions from serviceability > code" > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8035952 > > Webrev: > http://cr.openjdk.java.net/~fparain/8035952/webrev.00/ > > Tested with jdk_management test suite + manual tests > to verify consistency of values returned by new code. > > Thank you, > > Fred > > -- > Frederic Parain - Oracle > Grenoble Engineering Center - France > Phone: +33 4 76 18 81 17 > Email: frederic.par...@oracle.com