Done, and thanks for the reviews. Mikael
On 2014-05-05 20:24, Staffan Larsen wrote: > Mikael, > > I just the final review for JDK-8031126 so I will be pushing that shortly to > jdk9/hs-rt. Would you mind removing that entry from your change (unless you > have already pushed it). > > Thanks, > /Staffan > > On 5 maj 2014, at 16:42, Mikael Auno <mikael.a...@oracle.com> wrote: > >> Thanks for spotting it. New webrev at >> http://cr.openjdk.java.net/~miauno/8040748/webrev.03/. >> >> Mikael >> >> On 2014-05-05 16:18, Staffan Larsen wrote: >>> 8039432 is Resolved and should not be listed. >>> >>> /Staffan >>> >>> On 5 maj 2014, at 15:26, Mikael Auno <mikael.a...@oracle.com> wrote: >>> >>>> I've updated this change to use ProblemList.txt instead of @ignore >>>> (since that was only intended for hotspot/test and not jdk/test). I've >>>> also updated the data to nightly failures from the last two weeks with >>>> issues since then filtered out manually. >>>> >>>> Hopefully this should address all concerns. >>>> >>>> New webrev at http://cr.openjdk.java.net/~miauno/8040748/webrev.02/ >>>> >>>> Thanks, >>>> Mikael >>>> >>>> On 2014-04-25 08:15, Staffan Larsen wrote: >>>>> For test/com/sun/jdi/JdbReadTwiceTest.sh, you list JDK-8002116, but that >>>>> bug is resolved so should not be reason to quarantine the test. >>>>> >>>>> For test/com/sun/jdi/RepStep.java you list JDK-6471769 JDK-6766320 but >>>>> both of those are closed so should not be reason to quarantine the test. >>>>> >>>>> For test/demo/jvmti/mtrace/TraceJFrame.java you list JDK-8035195 and >>>>> JDK-8039432, but 8035195 seems to be just an old name for 8039432 >>>>> (looking it up in JBS takes you to 8039432). So 8035195 should not be >>>>> listed. >>>>> >>>>> For test/sun/tools/jinfo/Basic.sh, there are no open bugs against it >>>>> (except JDK-6542634 which is a timeout from 2007 and I’m not sure it is >>>>> valid) so I don’t think it should be quarantined. >>>>> >>>>> /Staffan >>>>> >>>>> >>>>> On 24 apr 2014, at 20:01, Mikael Auno <mikael.a...@oracle.com> wrote: >>>>> >>>>>> I've now added the keyword "quarantine" as well as fixed an issue with >>>>>> placement of the @ignore tag (it's not allowed to come before @library). >>>>>> >>>>>> New webrev at http://cr.openjdk.java.net/~miauno/8040748/webrev.01/ >>>>>> >>>>>> Local testing: >>>>>> >>>>>>> % jtreg -jdk $JAVA_HOME -k:quarantine -ignore:quiet -verbose:summary >>>>>>> /localhome/ws/jdk9-dev/jdk/test/ >>>>>>> Test results: no tests selected >>>>>>> Report written to /localhome/temp/run/JTreport/html/report.html >>>>>>> Results written to /localhome/temp/run/JTwork >>>>>> >>>>>> Thanks, >>>>>> Mikael >>>>>> >>>>>> On 2014-04-22 17:12, Stefan Särne wrote: >>>>>>> Hi Mikael, >>>>>>> >>>>>>> I think we should use a key word to group quarantined tests, which can >>>>>>> be used to run the tests as a separate batch. Recommend to add this to >>>>>>> all tests: >>>>>>> @key quarantine >>>>>>> >>>>>>> Note that you may have to add the key word as a known key word to the >>>>>>> TEST.ROOT file as well. >>>>>>> >>>>>>> Best regards, >>>>>>> Stefan >>>>>>> >>>>>>> -----Original Message----- >>>>>>> From: Mikael Auno >>>>>>> Sent: den 16 april 2014 19:51 >>>>>>> To: serviceability-dev@openjdk.java.net >>>>>>> Subject: RFR 8040748: [TESTBUG] Exclude failing (serviceability) jtreg >>>>>>> tests using @ignore >>>>>>> >>>>>>> Please, review the following fix adding the @ignore tag to a couple of >>>>>>> serviceability tests >>>>>>> >>>>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8040748 >>>>>>> Webrev: http://cr.openjdk.java.net/~miauno/8040748/webrev.00/ >>>>>>> >>>>>>> Thanks, >>>>>>> Mikael >>>>>>> >>>>>> >>>>> >>>> >>> >> >
