On 10 jun 2014, at 09:40, Alan Bateman <alan.bate...@oracle.com> wrote:
> On 10/06/2014 08:09, Staffan Larsen wrote: >> : >> >> >> An updated webrev is here: http://cr.openjdk.java.net/~sla/8044135/webrev.01/ > To David's point about IAE vs. NPE then this API throws NPE when passed a > null so it would be good to keep that consistent. Changed: http://cr.openjdk.java.net/~sla/8044135/webrev.02/ > I don't think I've come across @SuppressedWarnings("unused") before - if > these methods are never called in the tests then can't they be removed? They are used, but only via reflection from the main() method. Eclipse, at least, can’t see that so flags them as “unused” - minor annoyance. Thank, /Staffan
