On 10/06/2014 08:46, Staffan Larsen wrote:
Changed: http://cr.openjdk.java.net/~sla/8044135/webrev.02/
I took another pass over this (webrev.03, latest I think).
Now that the NPE issue is resolved then I think it means that
VirtualMachine#startManagementAgent needs to @throws
IllegalArgumentException in its javadoc to make it clear that this is
throw when non-String or other validation fails. It probably doesn't
have to specify that the properties have to start with
com.sun.management as that might change over time.
It otherwise looks okay to me, I guess I would leave out the Eclipse
specific @SuppressWarnings("unused") as we don't usually use this in the
JDK code base for non-javac warnings.
-Alan
