On 08/09/2014 13:25, Staffan Larsen wrote:
This looks to me. I guess I'd probably use "pis" (or even "in") for the piped input stream but it's immaterial here.Two fixes: - The PipedInputStream used by the attach code on windows is not closed in case of errors - The InputStreams returned by VirtualMachine.execute are not closed by all callerswebrev: http://cr.openjdk.java.net/~sla/8057558/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8057558
-Alan